Re: [Qemu-devel] [PATCH v3 24/36] s390x: convert s390-virtio to hotplug handler API

[Igor Mammedov <imammedo@redhat.com>]

On Fri, 26 Sep 2014 14:15:48 +0200
Cornelia Huck <cornelia.huck@de.ibm.com> wrote:

> On Fri, 26 Sep 2014 12:08:16 +0000
> Igor Mammedov <imammedo@redhat.com> wrote:
> 
> > beside of conversion, patch drops present unplug
> > handling, effectively disabling hot-unplug of
> > s390-virtio devices.
> > 
> > Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> > ---
> > v3:
> >  disable unplug, Cornelia Huck <cornelia.huck@de.ibm.com>
> > v2:
> >  fix not working unplug
> > ---
> >  hw/s390x/s390-virtio-bus.c | 11 ++++++-----
> >  1 file changed, 6 insertions(+), 5 deletions(-)
> > 
> > diff --git a/hw/s390x/s390-virtio-bus.c b/hw/s390x/s390-virtio-bus.c
> > index 6b6fb61..7fa47d4 100644
> > --- a/hw/s390x/s390-virtio-bus.c
> > +++ b/hw/s390x/s390-virtio-bus.c
> 
> > @@ -674,6 +673,7 @@ static int s390_virtio_bridge_init(SysBusDevice *dev)
> >  static void s390_virtio_bridge_class_init(ObjectClass *klass, void *data)
> >  {
> >      SysBusDeviceClass *k = SYS_BUS_DEVICE_CLASS(klass);
> > +    HotplugHandlerClass *hc = HOTPLUG_HANDLER_CLASS(klass);
> 
> This line is not needed (and gives an error for me).
Ops, sorry.
I'll fix it.

> 
> > 
> >      k->init = s390_virtio_bridge_init;
> >  }
> 
>