From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40068)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1XXUeK-0000lU-Su
	for qemu-devel@nongnu.org; Fri, 26 Sep 2014 08:29:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1XXUeE-0006Mw-PC
	for qemu-devel@nongnu.org; Fri, 26 Sep 2014 08:29:24 -0400
Received: from mx1.redhat.com ([209.132.183.28]:51890)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1XXUeE-0006Lj-Hu
	for qemu-devel@nongnu.org; Fri, 26 Sep 2014 08:29:18 -0400
Date: Fri, 26 Sep 2014 14:29:06 +0200
From: Igor Mammedov <imammedo@redhat.com>
Message-ID: <20140926142906.6f7fe84f@nial.usersys.redhat.com>
In-Reply-To: <20140926141548.502ce035.cornelia.huck@de.ibm.com>
References: <1411723721-20484-25-git-send-email-imammedo@redhat.com>
	<1411733296-19250-1-git-send-email-imammedo@redhat.com>
	<20140926141548.502ce035.cornelia.huck@de.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 24/36] s390x: convert s390-virtio to
 hotplug handler API
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: qemu-devel@nongnu.org

On Fri, 26 Sep 2014 14:15:48 +0200
Cornelia Huck <cornelia.huck@de.ibm.com> wrote:

> On Fri, 26 Sep 2014 12:08:16 +0000
> Igor Mammedov <imammedo@redhat.com> wrote:
> 
> > beside of conversion, patch drops present unplug
> > handling, effectively disabling hot-unplug of
> > s390-virtio devices.
> > 
> > Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> > ---
> > v3:
> >  disable unplug, Cornelia Huck <cornelia.huck@de.ibm.com>
> > v2:
> >  fix not working unplug
> > ---
> >  hw/s390x/s390-virtio-bus.c | 11 ++++++-----
> >  1 file changed, 6 insertions(+), 5 deletions(-)
> > 
> > diff --git a/hw/s390x/s390-virtio-bus.c b/hw/s390x/s390-virtio-bus.c
> > index 6b6fb61..7fa47d4 100644
> > --- a/hw/s390x/s390-virtio-bus.c
> > +++ b/hw/s390x/s390-virtio-bus.c
> 
> > @@ -674,6 +673,7 @@ static int s390_virtio_bridge_init(SysBusDevice *dev)
> >  static void s390_virtio_bridge_class_init(ObjectClass *klass, void *data)
> >  {
> >      SysBusDeviceClass *k = SYS_BUS_DEVICE_CLASS(klass);
> > +    HotplugHandlerClass *hc = HOTPLUG_HANDLER_CLASS(klass);
> 
> This line is not needed (and gives an error for me).
Ops, sorry.
I'll fix it.

> 
> > 
> >      k->init = s390_virtio_bridge_init;
> >  }
> 
>