From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47201)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cornelia.huck@de.ibm.com>) id 1XXVEk-0001gZ-1Q
	for qemu-devel@nongnu.org; Fri, 26 Sep 2014 09:07:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <cornelia.huck@de.ibm.com>) id 1XXVEb-0007ll-0g
	for qemu-devel@nongnu.org; Fri, 26 Sep 2014 09:07:01 -0400
Received: from e06smtp15.uk.ibm.com ([195.75.94.111]:56144)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cornelia.huck@de.ibm.com>) id 1XXVEa-0007kw-Np
	for qemu-devel@nongnu.org; Fri, 26 Sep 2014 09:06:52 -0400
Received: from /spool/local
	by e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <cornelia.huck@de.ibm.com>;
	Fri, 26 Sep 2014 14:06:46 +0100
Received: from b06cxnps4076.portsmouth.uk.ibm.com
	(d06relay13.portsmouth.uk.ibm.com [9.149.109.198])
	by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id D0C8C2190045
	for <qemu-devel@nongnu.org>; Fri, 26 Sep 2014 14:06:22 +0100 (BST)
Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com
	[9.149.37.228])
	by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with
	ESMTP id s8QD6hb640894540
	for <qemu-devel@nongnu.org>; Fri, 26 Sep 2014 13:06:43 GMT
Received: from d06av02.portsmouth.uk.ibm.com (localhost [127.0.0.1])
	by d06av02.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with
	ESMTP id s8QD6h8f015421
	for <qemu-devel@nongnu.org>; Fri, 26 Sep 2014 07:06:43 -0600
Date: Fri, 26 Sep 2014 15:06:41 +0200
From: Cornelia Huck <cornelia.huck@de.ibm.com>
Message-ID: <20140926150641.78c8c066.cornelia.huck@de.ibm.com>
In-Reply-To: <1411735050-27334-1-git-send-email-imammedo@redhat.com>
References: <1411723721-20484-25-git-send-email-imammedo@redhat.com>
	<1411735050-27334-1-git-send-email-imammedo@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v4 24/36] s390x: convert s390-virtio to
 hotplug handler API
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Igor Mammedov <imammedo@redhat.com>
Cc: qemu-devel@nongnu.org

On Fri, 26 Sep 2014 12:37:30 +0000
Igor Mammedov <imammedo@redhat.com> wrote:

> beside of conversion, patch drops present unplug
> handling, effectively disabling hot-unplug of
> s390-virtio devices.
> 
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> ---
> v4:
>  fix build break due to unused variable
> v3:
>  disable unplug, Cornelia Huck <cornelia.huck@de.ibm.com>
> v2:
>  fix not working unplug
> ---
>  hw/s390x/s390-virtio-bus.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)

Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>