From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56714) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XXViM-0008BT-3w for qemu-devel@nongnu.org; Fri, 26 Sep 2014 09:37:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XXViG-0000qA-0i for qemu-devel@nongnu.org; Fri, 26 Sep 2014 09:37:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44518) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XXViF-0000oV-PW for qemu-devel@nongnu.org; Fri, 26 Sep 2014 09:37:31 -0400 Date: Fri, 26 Sep 2014 15:37:17 +0200 From: Igor Mammedov Message-ID: <20140926153717.1a87a0ee@nial.usersys.redhat.com> In-Reply-To: <1410917043-16334-8-git-send-email-guz.fnst@cn.fujitsu.com> References: <1410917043-16334-1-git-send-email-guz.fnst@cn.fujitsu.com> <1410917043-16334-8-git-send-email-guz.fnst@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V3 7/7] acpi/cpu-hotplug: introduce help function to keep bit setting in one place List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gu Zheng Cc: chen.fan.fnst@cn.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com, tangchen@cn.fujitsu.com, qemu-devel@nongnu.org, afaerber@suse.de On Wed, 17 Sep 2014 09:24:03 +0800 Gu Zheng wrote: > Introduce help function acpi_set_local_sts() to simplify acpi_cpu_plug_cb > and acpi_cpu_hotplug_init, so that we can keep bit setting in one place. > > Signed-off-by: Gu Zheng > --- > hw/acpi/cpu_hotplug.c | 22 +++++++++++++++------- > 1 files changed, 15 insertions(+), 7 deletions(-) > > diff --git a/hw/acpi/cpu_hotplug.c b/hw/acpi/cpu_hotplug.c > index 7629686..d42c961 100644 > --- a/hw/acpi/cpu_hotplug.c > +++ b/hw/acpi/cpu_hotplug.c > @@ -36,8 +36,8 @@ static const MemoryRegionOps AcpiCpuHotplug_ops = { > }, > }; > > -void acpi_cpu_plug_cb(ACPIREGS *ar, qemu_irq irq, > - AcpiCpuHotplug *g, CPUState *cpu, Error **errp) > +static void acpi_set_local_sts(AcpiCpuHotplug *g, CPUState *cpu, > + Error **errp) > { > CPUClass *k = CPU_GET_CLASS(cpu); > int64_t cpu_id; > @@ -48,9 +48,18 @@ void acpi_cpu_plug_cb(ACPIREGS *ar, qemu_irq irq, > return; > } > > - ar->gpe.sts[0] |= ACPI_CPU_HOTPLUG_STATUS; > g->sts[cpu_id / 8] |= (1 << (cpu_id % 8)); > +} > > +void acpi_cpu_plug_cb(ACPIREGS *ar, qemu_irq irq, > + AcpiCpuHotplug *g, CPUState *cpu, Error **errp) > +{ > + acpi_set_local_sts(g, cpu, errp); > + if (*errp != NULL) { > + return; > + } > + > + ar->gpe.sts[0] |= ACPI_CPU_HOTPLUG_STATUS; ^^^ shouldn't be set for coldplugged CPUs along with IRQ below > acpi_update_sci(ar, irq); > } > > @@ -60,11 +69,10 @@ void acpi_cpu_hotplug_init(MemoryRegion *parent, Object *owner, > CPUState *cpu; > > CPU_FOREACH(cpu) { > - CPUClass *cc = CPU_GET_CLASS(cpu); > - int64_t id = cc->get_arch_id(cpu); > + Error *local_err = NULL; > > - g_assert((id / 8) < ACPI_GPE_PROC_LEN); > - gpe_cpu->sts[id / 8] |= (1 << (id % 8)); > + acpi_set_local_sts(gpe_cpu, cpu, &local_err); > + g_assert(local_err == NULL); Wouldn't acpi_cpu_plug_cb() do everything this FOREACH does? I've suggest to drop CPU_FOREACH() altogether. > } > memory_region_init_io(&gpe_cpu->io, owner, &AcpiCpuHotplug_ops, > gpe_cpu, "acpi-cpu-hotplug", ACPI_GPE_PROC_LEN);