From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51999) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYRCf-0000UP-Tb for qemu-devel@nongnu.org; Sun, 28 Sep 2014 23:00:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XYRCW-00067V-MF for qemu-devel@nongnu.org; Sun, 28 Sep 2014 23:00:45 -0400 Received: from e28smtp04.in.ibm.com ([122.248.162.4]:42956) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYRCV-00065p-Tw for qemu-devel@nongnu.org; Sun, 28 Sep 2014 23:00:36 -0400 Received: from /spool/local by e28smtp04.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 29 Sep 2014 08:30:27 +0530 Received: from d28relay02.in.ibm.com (d28relay02.in.ibm.com [9.184.220.59]) by d28dlp01.in.ibm.com (Postfix) with ESMTP id 7FDC4E0023 for ; Mon, 29 Sep 2014 08:33:07 +0530 (IST) Received: from d28av03.in.ibm.com (d28av03.in.ibm.com [9.184.220.65]) by d28relay02.in.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id s8T30imK32309322 for ; Mon, 29 Sep 2014 08:30:44 +0530 Received: from d28av03.in.ibm.com (localhost [127.0.0.1]) by d28av03.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s8T30K6k019766 for ; Mon, 29 Sep 2014 08:30:20 +0530 Date: Mon, 29 Sep 2014 08:30:15 +0530 From: Bharata B Rao Message-ID: <20140929030015.GA21207@in.ibm.com> References: <1409810785-12391-1-git-send-email-bharata@linux.vnet.ibm.com> <1409810785-12391-11-git-send-email-bharata@linux.vnet.ibm.com> <20140926172902.3b0bdf4a@nial.usersys.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140926172902.3b0bdf4a@nial.usersys.redhat.com> Subject: Re: [Qemu-devel] [RFC PATCH v0 10/15] ppc: Factor out CPU initialization code to a new routine Reply-To: bharata@linux.vnet.ibm.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com On Fri, Sep 26, 2014 at 05:29:02PM +0200, Igor Mammedov wrote: > On Thu, 4 Sep 2014 11:36:20 +0530 > Bharata B Rao wrote: > > > Separate out CPU initialization code into a new routine ppc_new_cpu() > > so that it can be used from CPU hotplug path too. > > > > Signed-off-by: Bharata B Rao > > --- > > hw/ppc/spapr.c | 73 +++++++++++++++++++++++++++++++++------------------------- > > 1 file changed, 42 insertions(+), 31 deletions(-) > > > > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c > > index b2ca527..41207ae 100644 > > --- a/hw/ppc/spapr.c > > +++ b/hw/ppc/spapr.c > > @@ -1603,6 +1603,45 @@ static SaveVMHandlers savevm_htab_handlers = { > > .load_state = htab_load, > > }; > > > looking at following code from POV of using CPU with device_add cmd. > > > +static const char *current_cpu_model; > do PPC CPUs use full 'model-name,feature1,-feature2' format or only > model-name from cpu_model string? I think it is just the model-name. > > > +static PowerPCCPU *ppc_new_cpu(const char *cpu_model) > > +{ > > + PowerPCCPU *cpu; > > + CPUPPCState *env; > > + > > + cpu = cpu_ppc_init(cpu_model); > > + if (cpu == NULL) { > > + fprintf(stderr, "Unable to find PowerPC CPU definition\n"); > > + exit(1); > > + } > > -- cut -- > > + env = &cpu->env; > > + > > + /* Set time-base frequency to 512 MHz */ > > + cpu_ppc_tb_init(env, TIMEBASE_FREQ); > > + > > + /* PAPR always has exception vectors in RAM not ROM. To ensure this, > > + * MSR[IP] should never be set. > > + */ > > + env->msr_mask &= ~(1 << 6); > > + > > + /* Tell KVM that we're in PAPR mode */ > > + if (kvm_enabled()) { > > + kvmppc_set_papr(cpu); > > + } > > + > > + if (cpu->max_compat) { > > + if (ppc_set_compat(cpu, cpu->max_compat) < 0) { > > + exit(1); > > + } > > + } > -- cut -- > selected block looks like setting CPU internals, which could be done > inside of CPU's realizefn. > > > + > > + xics_cpu_setup(spapr->icp, cpu); > > > > + qemu_register_reset(spapr_cpu_reset, cpu); > also could be put inside of CPU's realizefn, like it's done in > for x86 CPU. Right, I just converted my CPU hotplug patchset for PowerPC to use the hotplug handler APIs and now working on to see if I can switch over to device_add and support device_del for CPU hotplug on PowerPC. Regards, Bharata.