From: Kevin Wolf <kwolf@redhat.com>
To: Zhang Haoyu <zhanghy@sangfor.com>
Cc: xiawenc <xiawenc@linux.vnet.ibm.com>,
qemu-stable@nongnu.org, qemu-devel <qemu-devel@nongnu.org>,
Stefan Hajnoczi <stefanha@redhat.com>,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH bugfix v2] snapshot: fix referencing wrong variable in while loop in do_delvm
Date: Mon, 29 Sep 2014 11:51:43 +0200 [thread overview]
Message-ID: <20140929095143.GB3910@noname.str.redhat.com> (raw)
In-Reply-To: <201409291637594172481@sangfor.com>
Am 29.09.2014 um 10:38 hat Zhang Haoyu geschrieben:
> The while loop variabal is "bs1",
> but "bs" is always passed to bdrv_snapshot_delete_by_id_or_name.
> Broken in commit a89d89d, v1.7.0.
>
> v1 -> v2:
> * add broken commit id to commit message
>
> Signed-off-by: Zhang Haoyu <zhanghy@sangfor.com>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
Cc: qemu-stable@nongnu.org
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
We should probably add a qemu-iotests case for the handling of internal
snapshots on VMs with multiple images. Any volunteer?
Kevin
next prev parent reply other threads:[~2014-09-29 9:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-29 8:38 [Qemu-devel] [PATCH bugfix v2] snapshot: fix referencing wrong variable in while loop in do_delvm Zhang Haoyu
2014-09-29 9:18 ` Markus Armbruster
2014-09-29 9:54 ` Stefan Hajnoczi
2014-09-29 9:51 ` Kevin Wolf [this message]
2014-09-29 10:15 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140929095143.GB3910@noname.str.redhat.com \
--to=kwolf@redhat.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=stefanha@redhat.com \
--cc=xiawenc@linux.vnet.ibm.com \
--cc=zhanghy@sangfor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).