From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51505)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1XYXcd-0001vF-5Y
	for qemu-devel@nongnu.org; Mon, 29 Sep 2014 05:51:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1XYXcc-00047f-4b
	for qemu-devel@nongnu.org; Mon, 29 Sep 2014 05:51:59 -0400
Date: Mon, 29 Sep 2014 11:51:43 +0200
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20140929095143.GB3910@noname.str.redhat.com>
References: <201409291637594172481@sangfor.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201409291637594172481@sangfor.com>
Subject: Re: [Qemu-devel] [PATCH bugfix v2] snapshot: fix referencing wrong
 variable in while loop in do_delvm
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Zhang Haoyu <zhanghy@sangfor.com>
Cc: xiawenc <xiawenc@linux.vnet.ibm.com>, qemu-stable@nongnu.org, qemu-devel <qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@redhat.com>, Markus Armbruster <armbru@redhat.com>

Am 29.09.2014 um 10:38 hat Zhang Haoyu geschrieben:
> The while loop variabal is "bs1", 
> but "bs" is always passed to bdrv_snapshot_delete_by_id_or_name.
> Broken in commit a89d89d, v1.7.0.
> 
> v1 -> v2:
> * add broken commit id to commit message
> 
> Signed-off-by: Zhang Haoyu <zhanghy@sangfor.com>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>

Cc: qemu-stable@nongnu.org
Reviewed-by: Kevin Wolf <kwolf@redhat.com>

We should probably add a qemu-iotests case for the handling of internal
snapshots on VMs with multiple images. Any volunteer?

Kevin