From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51940)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1XYXfg-0003BY-56
	for qemu-devel@nongnu.org; Mon, 29 Sep 2014 05:55:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1XYXfb-00053t-0x
	for qemu-devel@nongnu.org; Mon, 29 Sep 2014 05:55:08 -0400
Date: Mon, 29 Sep 2014 10:54:54 +0100
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20140929095454.GD27760@stefanha-thinkpad.redhat.com>
References: <201409291637594172481@sangfor.com>
	<87fvfapyxi.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="qGV0fN9tzfkG3CxV"
Content-Disposition: inline
In-Reply-To: <87fvfapyxi.fsf@blackfin.pond.sub.org>
Subject: Re: [Qemu-devel] [PATCH bugfix v2] snapshot: fix referencing wrong
 variable in while loop in do_delvm
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Zhang Haoyu <zhanghy@sangfor.com>, qemu-devel <qemu-devel@nongnu.org>, qemu-stable@nongnu.org


--qGV0fN9tzfkG3CxV
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Sep 29, 2014 at 11:18:33AM +0200, Markus Armbruster wrote:
> > The while loop variabal is "bs1",=20
> > but "bs" is always passed to bdrv_snapshot_delete_by_id_or_name.
> > Broken in commit a89d89d, v1.7.0.
> >
> > v1 -> v2:
> > * add broken commit id to commit message
>=20
> Patch version information...
>=20
> > Signed-off-by: Zhang Haoyu <zhanghy@sangfor.com>
> > Reviewed-by: Markus Armbruster <armbru@redhat.com>
> > ---
>=20
> ... goes here, so it doesn't go into the permanent commit message.
> Maybe Kevin or Stefan can clean it up on commit.

No problem, we'll drop the changelog when applying the patch this time.

Thanks for reviewing, Markus.

--qGV0fN9tzfkG3CxV
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJUKSxuAAoJEJykq7OBq3PIwcsH/jigBbmJTDkFm7vTP35fBrlN
HGzsIJnJPwemdragN14TxuX29eaJmBp/iJVdGvTLV31Wn+cA1E00zKLR0gvlhd7K
xXBnwNXeZ5XZMkKdm3QvhICOTrcqfmBEZrYM/eypuEmZ+pr+2JemyeD85Taqot4Q
p5T/gmycL101lWvqMgKYj3b/GVytMm/QBLXpYlC/FPvV+jxEOZqv985qCsPzPFU6
rHxVdLVDSgwoixW6zpKi5wPBW/tPemZkwii42+m3dhWueVUmoEOqZhlp2hQTe45I
WeQP9RlMPDXYZ135aWt7H4gaWkt9tCrAaCDwraET8cg3iNCUoOaEJpfl9lRNtgA=
=NhTh
-----END PGP SIGNATURE-----

--qGV0fN9tzfkG3CxV--