From: "Michael S. Tsirkin" <mst@redhat.com>
To: Alex Bligh <alex@alex.org.uk>
Cc: "Ryan Harper" <ryan.harper@canonical.com>,
"Serge Hallyn" <serge.hallyn@canonical.com>,
"quintela@redhat.com" <quintela@redhat.com>,
Libvirt <libvir-list@redhat.com>,
"Serge Hallyn" <serge.hallyn@ubuntu.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"Alexander Graf" <agraf@suse.de>,
"Cole Robinson" <crobinso@redhat.com>,
"Amit Shah" <amit.shah@redhat.com>,
"Bruce Rogers" <brogers@suse.com>,
"Andreas Färber" <afaerber@suse.de>,
"Serge E. Hallyn" <serge@hallyn.com>
Subject: Re: [Qemu-devel] [PATCH v4] Add machine parameter qemu-kvm-migration for live migrate compatibility with qemu-kvm
Date: Mon, 29 Sep 2014 13:08:56 +0300 [thread overview]
Message-ID: <20140929100856.GB32459@redhat.com> (raw)
In-Reply-To: <C342FF40-40B1-489C-A958-FFFD509CC1FA@alex.org.uk>
On Sun, Sep 28, 2014 at 09:33:08PM +0100, Alex Bligh wrote:
> Hang on a second! v2 of this patch DID use a new virtual machine,
> called exactly that. I thought you were objecting to that and
> wanting a machine parameter instead! It's far easier with a new
> machine type, and I'd far prefer a new machine type.
>
> If you were just objecting to the fact that pc-1.0 was made to
> be an alias of either one or the other at compile time, simply
> drop the second patch of the v2 patchset.
I think same applies to v3 that I reviewed right?
Absolutely, I'm fine with just a new machine type.
This means that management tools will need to learn to
add -qemu-kvm suffix to the machine name if user
requested compatibility with qemu-kvm.
I think there were some implementation issues with patch 1/2
though.
> If we have a new machine type, I don't /think/ I need the early_init
> thing at all (I may be wrong about that).
Good.
> --
> Alex Bligh
>
>
>
next prev parent reply other threads:[~2014-09-29 10:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-22 19:34 [Qemu-devel] [PATCH v4] Add machine parameter qemu-kvm-migration for live migrate compatibility with qemu-kvm Alex Bligh
2014-09-22 19:34 ` Alex Bligh
2014-09-28 15:30 ` Michael S. Tsirkin
2014-09-28 20:33 ` Alex Bligh
2014-09-29 7:02 ` Markus Armbruster
2014-10-05 7:00 ` Paolo Bonzini
2014-10-05 10:26 ` Alex Bligh
2014-10-05 12:26 ` Paolo Bonzini
2014-10-05 12:48 ` Michael S. Tsirkin
2014-10-05 13:30 ` Paolo Bonzini
2014-09-29 10:08 ` Michael S. Tsirkin [this message]
2014-09-29 10:13 ` Alex Bligh
2014-09-29 14:52 ` Serge E. Hallyn
2014-10-04 16:29 ` Alex Bligh
2014-09-24 8:05 ` Markus Armbruster
2014-09-24 8:29 ` Alex Bligh
2014-09-24 8:38 ` Michael Tokarev
2014-09-25 8:02 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140929100856.GB32459@redhat.com \
--to=mst@redhat.com \
--cc=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=alex@alex.org.uk \
--cc=amit.shah@redhat.com \
--cc=brogers@suse.com \
--cc=crobinso@redhat.com \
--cc=libvir-list@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=ryan.harper@canonical.com \
--cc=serge.hallyn@canonical.com \
--cc=serge.hallyn@ubuntu.com \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).