From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53400)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1XYXqA-0007J2-Dj
	for qemu-devel@nongnu.org; Mon, 29 Sep 2014 06:06:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1XYXq4-0007vw-A3
	for qemu-devel@nongnu.org; Mon, 29 Sep 2014 06:05:58 -0400
Received: from mx1.redhat.com ([209.132.183.28]:13326)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1XYXq3-0007vc-VO
	for qemu-devel@nongnu.org; Mon, 29 Sep 2014 06:05:52 -0400
Date: Mon, 29 Sep 2014 13:08:56 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20140929100856.GB32459@redhat.com>
References: <1411414496-46245-1-git-send-email-alex@alex.org.uk>
	<1411414496-46245-2-git-send-email-alex@alex.org.uk>
	<20140928153058.GA4994@redhat.com>
	<C342FF40-40B1-489C-A958-FFFD509CC1FA@alex.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <C342FF40-40B1-489C-A958-FFFD509CC1FA@alex.org.uk>
Subject: Re: [Qemu-devel] [PATCH v4] Add machine parameter
 qemu-kvm-migration for live migrate compatibility with qemu-kvm
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alex Bligh <alex@alex.org.uk>
Cc: Ryan Harper <ryan.harper@canonical.com>, Serge Hallyn <serge.hallyn@canonical.com>, "quintela@redhat.com" <quintela@redhat.com>, Libvirt <libvir-list@redhat.com>, Serge Hallyn <serge.hallyn@ubuntu.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, Alexander Graf <agraf@suse.de>, Cole Robinson <crobinso@redhat.com>, Amit Shah <amit.shah@redhat.com>, Bruce Rogers <brogers@suse.com>, Andreas =?iso-8859-1?Q?F=E4rber?= <afaerber@suse.de>, "Serge E. Hallyn" <serge@hallyn.com>

On Sun, Sep 28, 2014 at 09:33:08PM +0100, Alex Bligh wrote:
> Hang on a second! v2 of this patch DID use a new virtual machine,
> called exactly that. I thought you were objecting to that and
> wanting a machine parameter instead! It's far easier with a new
> machine type, and I'd far prefer a new machine type.
> 
> If you were just objecting to the fact that pc-1.0 was made to
> be an alias of either one or the other at compile time, simply
> drop the second patch of the v2 patchset.

I think same applies to v3 that I reviewed right?
Absolutely, I'm fine with just a new machine type.
This means that management tools will need to learn to
add -qemu-kvm suffix to the machine name if user
requested compatibility with qemu-kvm.
I think there were some implementation issues with patch 1/2
though.

> If we have a new machine type, I don't /think/ I need the early_init
> thing at all (I may be wrong about that).

Good.

> -- 
> Alex Bligh
> 
> 
>