From: Stefan Hajnoczi <stefanha@redhat.com>
To: Zhang Haoyu <zhanghy@sangfor.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
xiawenc <xiawenc@linux.vnet.ibm.com>,
qemu-devel <qemu-devel@nongnu.org>,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH bugfix v2] snapshot: fix referencing wrong variable in while loop in do_delvm
Date: Mon, 29 Sep 2014 11:15:55 +0100 [thread overview]
Message-ID: <20140929101555.GA28435@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <201409291637594172481@sangfor.com>
[-- Attachment #1: Type: text/plain, Size: 560 bytes --]
On Mon, Sep 29, 2014 at 04:38:02PM +0800, Zhang Haoyu wrote:
> The while loop variabal is "bs1",
> but "bs" is always passed to bdrv_snapshot_delete_by_id_or_name.
> Broken in commit a89d89d, v1.7.0.
>
> v1 -> v2:
> * add broken commit id to commit message
>
> Signed-off-by: Zhang Haoyu <zhanghy@sangfor.com>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
> ---
> savevm.c | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2014-09-29 10:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-29 8:38 [Qemu-devel] [PATCH bugfix v2] snapshot: fix referencing wrong variable in while loop in do_delvm Zhang Haoyu
2014-09-29 9:18 ` Markus Armbruster
2014-09-29 9:54 ` Stefan Hajnoczi
2014-09-29 9:51 ` Kevin Wolf
2014-09-29 10:15 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140929101555.GA28435@stefanha-thinkpad.redhat.com \
--to=stefanha@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=xiawenc@linux.vnet.ibm.com \
--cc=zhanghy@sangfor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).