From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55219)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1XYY01-0005I3-Uz
	for qemu-devel@nongnu.org; Mon, 29 Sep 2014 06:16:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1XYXzx-0002EU-Nb
	for qemu-devel@nongnu.org; Mon, 29 Sep 2014 06:16:09 -0400
Received: from mx1.redhat.com ([209.132.183.28]:17217)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1XYXzx-0002E6-G7
	for qemu-devel@nongnu.org; Mon, 29 Sep 2014 06:16:05 -0400
Date: Mon, 29 Sep 2014 11:15:55 +0100
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20140929101555.GA28435@stefanha-thinkpad.redhat.com>
References: <201409291637594172481@sangfor.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="MGYHOYXEY6WxJCY8"
Content-Disposition: inline
In-Reply-To: <201409291637594172481@sangfor.com>
Subject: Re: [Qemu-devel] [PATCH bugfix v2] snapshot: fix referencing wrong
 variable in while loop in do_delvm
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Zhang Haoyu <zhanghy@sangfor.com>
Cc: Kevin Wolf <kwolf@redhat.com>, xiawenc <xiawenc@linux.vnet.ibm.com>, qemu-devel <qemu-devel@nongnu.org>, Markus Armbruster <armbru@redhat.com>


--MGYHOYXEY6WxJCY8
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Sep 29, 2014 at 04:38:02PM +0800, Zhang Haoyu wrote:
> The while loop variabal is "bs1",=20
> but "bs" is always passed to bdrv_snapshot_delete_by_id_or_name.
> Broken in commit a89d89d, v1.7.0.
>=20
> v1 -> v2:
> * add broken commit id to commit message
>=20
> Signed-off-by: Zhang Haoyu <zhanghy@sangfor.com>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
> ---
>  savevm.c | 11 +++++------
>  1 file changed, 5 insertions(+), 6 deletions(-)

Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block

Stefan

--MGYHOYXEY6WxJCY8
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJUKTFbAAoJEJykq7OBq3PIsfsH/imQdrBVNW8tXIPG+slj127j
TV7Swasyhjf09oeMsyNe+UUzbUatBxRibwbEdd/Khb6hJDbhA3n/pzQmHpg2HYxm
rTczxuRhWnzO4bvjfbjsFUGojkVxA5Pdk0uNmSD94JzK4XCuWcJ2h94IWGbE6dnz
ylTEvyIxb8JUPmLI2uAkPGwtJXqm9/JO8CjCOkVd6XuLaeOTjtb6wDQmuuUX+AIh
FVh5tIBPNuDgg3q4w5RRFc1DY0zkq8ngiHx4YSWqrkMJZxKBcAoZAYYL7qjIFz46
ZP2UUmEboT3M2krC4FEVQtVNWC1llZKtEZk8e6rsgtymYN6RPMWOKpkRp9Q4ftg=
=BHbf
-----END PGP SIGNATURE-----

--MGYHOYXEY6WxJCY8--