From: Stefan Hajnoczi <stefanha@gmail.com>
To: "Richard W.M. Jones" <rjones@redhat.com>
Cc: arei.gonglei@huawei.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] ssh: Don't crash if either host or path is not specified.
Date: Mon, 29 Sep 2014 11:20:32 +0100 [thread overview]
Message-ID: <20140929102032.GB28435@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1411977982-2093-1-git-send-email-rjones@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 795 bytes --]
On Mon, Sep 29, 2014 at 09:06:22AM +0100, Richard W.M. Jones wrote:
> $ ./qemu-img create -f qcow2 overlay \
> -b 'json: { "file.driver":"ssh",
> "file.host":"localhost",
> "file.host_key_check":"no" }'
> qemu-img: qobject/qdict.c:193: qdict_get_obj: Assertion `obj != ((void *)0)' failed.
> Aborted
>
> A similar crash also happens if the file.host field is omitted.
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1147343
>
> Bug found and reported by Jun Li.
>
> Signed-off-by: Richard W.M. Jones <rjones@redhat.com>
> ---
> block/ssh.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
Please CC Kevin Wolf and me on block patches.
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2014-09-29 10:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-29 8:06 [Qemu-devel] [PATCH v2] ssh: Don't crash if either host or path is not specified Richard W.M. Jones
2014-09-29 8:30 ` Gonglei (Arei)
2014-09-29 10:20 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140929102032.GB28435@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=arei.gonglei@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=rjones@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).