From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56151)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1XYY4W-0008Tw-1x
	for qemu-devel@nongnu.org; Mon, 29 Sep 2014 06:20:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1XYY4Q-0003V9-9e
	for qemu-devel@nongnu.org; Mon, 29 Sep 2014 06:20:48 -0400
Received: from mail-we0-x229.google.com ([2a00:1450:400c:c03::229]:38042)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1XYY4Q-0003UG-2V
	for qemu-devel@nongnu.org; Mon, 29 Sep 2014 06:20:42 -0400
Received: by mail-we0-f169.google.com with SMTP id k48so12640316wev.14
	for <qemu-devel@nongnu.org>; Mon, 29 Sep 2014 03:20:35 -0700 (PDT)
Date: Mon, 29 Sep 2014 11:20:32 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20140929102032.GB28435@stefanha-thinkpad.redhat.com>
References: <1411977982-2093-1-git-send-email-rjones@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="hHWLQfXTYDoKhP50"
Content-Disposition: inline
In-Reply-To: <1411977982-2093-1-git-send-email-rjones@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] ssh: Don't crash if either host or path
 is not specified.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Richard W.M. Jones" <rjones@redhat.com>
Cc: arei.gonglei@huawei.com, qemu-devel@nongnu.org


--hHWLQfXTYDoKhP50
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Sep 29, 2014 at 09:06:22AM +0100, Richard W.M. Jones wrote:
> $ ./qemu-img create -f qcow2 overlay \
>     -b 'json: { "file.driver":"ssh",
>                 "file.host":"localhost",
>                 "file.host_key_check":"no" }'
> qemu-img: qobject/qdict.c:193: qdict_get_obj: Assertion `obj !=3D ((void =
*)0)' failed.
> Aborted
>=20
> A similar crash also happens if the file.host field is omitted.
>=20
> https://bugzilla.redhat.com/show_bug.cgi?id=3D1147343
>=20
> Bug found and reported by Jun Li.
>=20
> Signed-off-by: Richard W.M. Jones <rjones@redhat.com>
> ---
>  block/ssh.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)

Please CC Kevin Wolf and me on block patches.

Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block

Stefan

--hHWLQfXTYDoKhP50
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJUKTJwAAoJEJykq7OBq3PIR+4H/iDKxra3gaPgNm+jCR/15vIi
jbEvYsb7BSaO0s1an4Z2sbQcxLPxl9471KOIjdV+gq6CEhOVNMmMWRmr9N7RXuvu
en+9Tc9mqy77X9xMdWnnP0zOv9dWGDNkaza/rV2cR1HCB+U4gtQxSfBdWTtOCf4Q
LEGps+Ex/HDKKLunSWvxyu9rG7SR5A6IvL8MmTdjCcppEY8SK08wsu+VJmQZ2UMf
coP38J+f1J5uz9pRWLXhuq+Bd78Z5AgxctC5gKIvr8rKPZ4pzLFox2i6+53yi4aG
FpCnEAzLgyv30lkzC4S0vuY6ELlbzrU/MYrjN1Y5rMIms0V5j2kBFn3H/Qt2q8Q=
=8FbF
-----END PGP SIGNATURE-----

--hHWLQfXTYDoKhP50--