From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57598) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYYD3-0007TG-D3 for qemu-devel@nongnu.org; Mon, 29 Sep 2014 06:29:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XYYCx-0005ct-9N for qemu-devel@nongnu.org; Mon, 29 Sep 2014 06:29:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52734) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYYCx-0005cY-2q for qemu-devel@nongnu.org; Mon, 29 Sep 2014 06:29:31 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8TATPbK015698 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Mon, 29 Sep 2014 06:29:25 -0400 Date: Mon, 29 Sep 2014 11:29:24 +0100 From: Stefan Hajnoczi Message-ID: <20140929102923.GD28435@stefanha-thinkpad.redhat.com> References: <1411968389-7353-1-git-send-email-famz@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="5p8PegU4iirBW1oA" Content-Disposition: inline In-Reply-To: <1411968389-7353-1-git-send-email-famz@redhat.com> Subject: Re: [Qemu-devel] [PATCH] main-loop: Use epoll on Linux List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: kwolf@redhat.com, Paolo Bonzini , qemu-devel@nongnu.org --5p8PegU4iirBW1oA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Sep 29, 2014 at 01:26:29PM +0800, Fam Zheng wrote: > +static bool g_poll_fds_changed(const GPollFD *fds_a, const guint nfds_a, > + const GPollFD *fds_b, const guint nfds_b) ... > +static inline int g_io_condition_from_epoll_events(int e) > +{ Please don't use the g_*() namespace. It belongs to glib and names could collide. Stefan --5p8PegU4iirBW1oA Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUKTSDAAoJEJykq7OBq3PI7WUH/3Vt+Yb+riyugC9lbYpXQlik JGqpUD8m4cgdVgL7iSk0GSavbVcuB5PnL8wNw6r2MIknXE0RRDyhLGG94H7tAwjy bTNjQr56ifBOK1SZn0+CByPJDJvwXuzbkgh6pgH1uGjbVj6BU0eDCWlfjCtWJZtz MzceztQbO8yfJLQyWCXwJEciQ+jbcrpEngrBhNmB0/CC9wSAi3jjy4ZTPhlUDpQB ZpU2HlpzYhL1oO6KwF7KMXUAVJFC1yypEvOEMBTL9F0dl9cf06j7zUvjNzjQ0bXK 0S12lUX9whDAMYHN6/A8vrvvYV5zm1fj1pbV2WkutmYx5uVEu2ptCgbhgInvfTg= =lIKC -----END PGP SIGNATURE----- --5p8PegU4iirBW1oA--