From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42696)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@nodalink.com>) id 1XYdRc-0005J3-2s
	for qemu-devel@nongnu.org; Mon, 29 Sep 2014 12:05:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <benoit.canet@nodalink.com>) id 1XYdRU-0002gX-Ac
	for qemu-devel@nongnu.org; Mon, 29 Sep 2014 12:04:59 -0400
Received: from dew.nodalink.com ([95.130.14.197]:39177)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@nodalink.com>) id 1XYdRU-0002fX-47
	for qemu-devel@nongnu.org; Mon, 29 Sep 2014 12:04:52 -0400
Date: Mon, 29 Sep 2014 16:04:44 +0000
From: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@nodalink.com>
Message-ID: <20140929160444.GC26702@nodalink.com>
References: <1411572065-18072-1-git-send-email-benoit.canet@nodalink.com>
	<1411572065-18072-3-git-send-email-benoit.canet@nodalink.com>
	<5422E459.1070708@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <5422E459.1070708@redhat.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v3 2/3] timers: Move
 NANOSECONDS_PER_SECONDS to timer.h for future reuse
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@nodalink.com>, armbru@redhat.com

On Wed, Sep 24, 2014 at 05:33:45PM +0200, Paolo Bonzini wrote:
> Il 24/09/2014 17:21, Beno=EEt Canet ha scritto:
> > Reviewed-by: Eric Blake <eblake@redhat.com>
> > Signed-off-by: Beno=EEt Canet <benoit.canet@nodalink.com>
> > ---
> >  include/qemu/throttle.h | 2 --
> >  include/qemu/timer.h    | 2 ++
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> >=20
> > diff --git a/include/qemu/throttle.h b/include/qemu/throttle.h
> > index 8f9e611..1c639d2 100644
> > --- a/include/qemu/throttle.h
> > +++ b/include/qemu/throttle.h
> > @@ -27,8 +27,6 @@
> >  #include "qemu-common.h"
> >  #include "qemu/timer.h"
> > =20
> > -#define NANOSECONDS_PER_SECOND  1000000000
> > -
> >  typedef enum {
> >      THROTTLE_BPS_TOTAL,
> >      THROTTLE_BPS_READ,
> > diff --git a/include/qemu/timer.h b/include/qemu/timer.h
> > index 5f5210d..0884e72 100644
> > --- a/include/qemu/timer.h
> > +++ b/include/qemu/timer.h
> > @@ -5,6 +5,8 @@
> >  #include "qemu-common.h"
> >  #include "qemu/notify.h"
> > =20
> > +#define NANOSECONDS_PER_SECOND  1000000000
> > +
> >  /* timers */
> > =20
> >  #define SCALE_MS 1000000
> >=20
>=20
> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
>=20
> :)

Two rev by for one commit are better than one but does this belong to
the third commit ? :)

Best regards

Beno=EEt