From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49805) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYk3P-0007t6-OI for qemu-devel@nongnu.org; Mon, 29 Sep 2014 19:08:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XYk3K-0005Zq-GJ for qemu-devel@nongnu.org; Mon, 29 Sep 2014 19:08:27 -0400 Received: from dew.nodalink.com ([95.130.14.197]:39226) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYk3J-0005Xy-Vd for qemu-devel@nongnu.org; Mon, 29 Sep 2014 19:08:22 -0400 Date: Mon, 29 Sep 2014 23:08:13 +0000 From: =?iso-8859-1?Q?Beno=EEt?= Canet Message-ID: <20140929230813.GF26702@nodalink.com> References: <1411572065-18072-1-git-send-email-benoit.canet@nodalink.com> <1411572065-18072-3-git-send-email-benoit.canet@nodalink.com> <5422E459.1070708@redhat.com> <20140929160444.GC26702@nodalink.com> <5429D527.5060008@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <5429D527.5060008@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 2/3] timers: Move NANOSECONDS_PER_SECONDS to timer.h for future reuse List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, =?iso-8859-1?Q?Beno=EEt?= Canet , armbru@redhat.com On Mon, Sep 29, 2014 at 11:54:47PM +0200, Paolo Bonzini wrote: > Il 29/09/2014 18:04, Beno=EEt Canet ha scritto: > > On Wed, Sep 24, 2014 at 05:33:45PM +0200, Paolo Bonzini wrote: > >> Il 24/09/2014 17:21, Beno=EEt Canet ha scritto: > >>> Reviewed-by: Eric Blake > >>> Signed-off-by: Beno=EEt Canet > >>> --- > >>> include/qemu/throttle.h | 2 -- > >>> include/qemu/timer.h | 2 ++ > >>> 2 files changed, 2 insertions(+), 2 deletions(-) > >>> > >>> diff --git a/include/qemu/throttle.h b/include/qemu/throttle.h > >>> index 8f9e611..1c639d2 100644 > >>> --- a/include/qemu/throttle.h > >>> +++ b/include/qemu/throttle.h > >>> @@ -27,8 +27,6 @@ > >>> #include "qemu-common.h" > >>> #include "qemu/timer.h" > >>> =20 > >>> -#define NANOSECONDS_PER_SECOND 1000000000 > >>> - > >>> typedef enum { > >>> THROTTLE_BPS_TOTAL, > >>> THROTTLE_BPS_READ, > >>> diff --git a/include/qemu/timer.h b/include/qemu/timer.h > >>> index 5f5210d..0884e72 100644 > >>> --- a/include/qemu/timer.h > >>> +++ b/include/qemu/timer.h > >>> @@ -5,6 +5,8 @@ > >>> #include "qemu-common.h" > >>> #include "qemu/notify.h" > >>> =20 > >>> +#define NANOSECONDS_PER_SECOND 1000000000 > >>> + > >>> /* timers */ > >>> =20 > >>> #define SCALE_MS 1000000 > >>> > >> > >> Reviewed-by: Paolo Bonzini > >> > >> :) > >=20 > > Two rev by for one commit are better than one but does this belong to > > the third commit ? :) >=20 > The rev-bys belong to the first and second. The third's on my list... >=20 I misread (freudian slip) the 20 seconds delta between the two rev-by as = 20 min. 20 min was credible but 20 seconds is not despite you being fast :) Best regards Beno=EEt > Paolo >=20