From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35778) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYlhN-00008d-MR for qemu-devel@nongnu.org; Mon, 29 Sep 2014 20:53:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XYlhJ-00043h-Lt for qemu-devel@nongnu.org; Mon, 29 Sep 2014 20:53:49 -0400 Received: from ozlabs.org ([2401:3900:2:1::2]:55404) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYlhJ-00043Q-88 for qemu-devel@nongnu.org; Mon, 29 Sep 2014 20:53:45 -0400 Date: Tue, 30 Sep 2014 10:43:50 +1000 From: David Gibson Message-ID: <20140930004350.GB7765@voom.fritz.box> References: <1411983073-13058-1-git-send-email-kraxel@redhat.com> <1411983073-13058-4-git-send-email-kraxel@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="TiqCXmo5T1hvSQQg" Content-Disposition: inline In-Reply-To: <1411983073-13058-4-git-send-email-kraxel@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 03/11] vga: Separate LE and BE conversion functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: David Gibson , qemu-devel@nongnu.org --TiqCXmo5T1hvSQQg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 29, 2014 at 11:31:04AM +0200, Gerd Hoffmann wrote: > From: Benjamin Herrenschmidt >=20 > Provide different functions for converting from an LE vs a BE > framebuffer. We cannot rely on the simple cases always being > shared surfaces since cirrus will need to always shadow for > cursor emulation, so we need the full set of functions to > be able to later handle runtime switching. >=20 > Signed-off-by: Benjamin Herrenschmidt \ > Signed-off-by: Gerd Hoffmann [snip] > @@ -1572,19 +1585,19 @@ static void vga_draw_graphic(VGACommonState *s, i= nt full_update) > bits =3D 8; > break; > case 15: > - v =3D VGA_DRAW_LINE15; > + v =3D big_endian_fb ? VGA_DRAW_LINE15_BE : VGA_DRAW_LINE15_L= E; > bits =3D 16; > break; > case 16: > - v =3D VGA_DRAW_LINE16; > + v =3D big_endian_fb ? VGA_DRAW_LINE16_BE : VGA_DRAW_LINE16_L= E; > bits =3D 16; > break; So, v1 changed both of these cases to bits =3D 15, which looked wrong for case 16. v2 changes neither, which looks wrong for case 15. Or is there a reason it should be 16 for case 15? --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --TiqCXmo5T1hvSQQg Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJUKfzGAAoJEGw4ysog2bOSUBMQAKLCHEpubebmnVhyasyvXe1b h/r8cdXn8c2lDM/uQfDFN/CeTUjLJgBctFveJqkWzHkBVYuavuQs+D+ez4dKP493 ynMGdInxtvmwLn9ez5EVLORypjyeE7MvUR7BrsuFeXD/SR6cSI3KWDvDunE7XhQw 5+ACh8/c5FTX7mrRcuxABnRpnZaukmGAmq9EbMroljqlqQ7K0Tf2UEiBGZzQTd+z eI7FsU63VaTQC1Erfp25bx7+7LTnpqRzqn5H6f/tUz7S67zflyvaluBS9SxeWIxy QlZAIacq1Bx/LTFrxkMcnd1Pkg7iXbrRlWxusLwe8W8Szf5cv8RpRWY0P8EO5lgT t0MUX+Y288LlPaDagV5Gtl08Wk/aPZC+ncI4T7jqyw5FQ4sSehJtg3VeBRhd8VIY E8XEOJ11HQK+eS6qBUtnO2oB/x59RSZilW3tt/n4IrbUsCgKS7UXvPKYSQf7989X I5VY/+AJhKuvC8AERAjS7OQH7dj0gNpLoAIGcqfpzTaPhlEr81hCRG5hikQjnc7z Fb1BhNSR+Shy/MFE5uO07LjRFBXD+aNkxk56wFRjY71KzT/TpCA8NI+teBqbfaUH U/FEC4Lea/l2bo5QxAVZoaujG5aZxqTwzSu69NY9mc+M3VDRVJSvj2nFQqQSO6n2 BruEbpkYV+9ylxB5YaAA =NO06 -----END PGP SIGNATURE----- --TiqCXmo5T1hvSQQg--