From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51346) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYtKH-00015F-LT for qemu-devel@nongnu.org; Tue, 30 Sep 2014 05:02:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XYtKG-0008Jy-AS for qemu-devel@nongnu.org; Tue, 30 Sep 2014 05:02:29 -0400 Received: from ozlabs.org ([2401:3900:2:1::2]:55528) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYtKF-0008Ht-Vk for qemu-devel@nongnu.org; Tue, 30 Sep 2014 05:02:28 -0400 Date: Tue, 30 Sep 2014 18:07:29 +1000 From: David Gibson Message-ID: <20140930080729.GA13852@voom.redhat.com> References: <1411983073-13058-1-git-send-email-kraxel@redhat.com> <1411983073-13058-4-git-send-email-kraxel@redhat.com> <20140930004350.GB7765@voom.fritz.box> <1412063970.23471.9.camel@nilsson.home.kraxel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="EVF5PPMfhYS0aIcm" Content-Disposition: inline In-Reply-To: <1412063970.23471.9.camel@nilsson.home.kraxel.org> Subject: Re: [Qemu-devel] [PATCH v2 03/11] vga: Separate LE and BE conversion functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: David Gibson , qemu-devel@nongnu.org --EVF5PPMfhYS0aIcm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Sep 30, 2014 at 09:59:30AM +0200, Gerd Hoffmann wrote: > Hi, >=20 > > > case 15: > > > - v =3D VGA_DRAW_LINE15; > > > + v =3D big_endian_fb ? VGA_DRAW_LINE15_BE : VGA_DRAW_LINE= 15_LE; > > > bits =3D 16; > > > break; > > > case 16: > > > - v =3D VGA_DRAW_LINE16; > > > + v =3D big_endian_fb ? VGA_DRAW_LINE16_BE : VGA_DRAW_LINE= 16_LE; > > > bits =3D 16; > > > break; > >=20 > > So, v1 changed both of these cases to bits =3D 15, which looked wrong > > for case 16. v2 changes neither, which looks wrong for case 15. Or > > is there a reason it should be 16 for case 15? >=20 > It is correct. The '15' is the color depth, and 'bits' is the number of > bits per pixel, which is 16 because the color format uses two bytes per > pixel and one of the bits is unused. Ok, then: Reviewed-by: David Gibson --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --EVF5PPMfhYS0aIcm Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJUKmTBAAoJEGw4ysog2bOSFOYQAJ2cu5IdmI+eEg9z5YqriLQA d53FaPQxloWebdfHRTTZgPl88RMh14H7xrZiEL77qYndUErYLRSzbjWl9Nq3K6VW s+OyswE5hg+e0fMtUX5YG9eIREK/DVfHV8zO4KgA7z3f4OZMusAj3aksKoykDyeX 9sJ4G6KV5t7FpHb2wz3JwDdvJBrSZ9Vhaj0YXy/rgMJ7ax63TEt23oQ1vf48Nzt3 W5s4djkRP+D8IZRZZEUbH5Ici4d14fi6+W3N+z5ZaA6v+Frcv6CFJdbFjQTTUN/l IfTqfhXiIl3Nu2SERJAgyY0vUV2QyBtd5KxdcYLKbnIh/RE0XUwSHH/fCggwU+9q xga/WAel4Q4eAyNfU1bCNagEYlVrtskuClqQOSeSkptpRyE47xq4YdH93Br8TgyX cqD4b+nTNOMFyJ+gkopTjBkPOLMEUsoloQy9G3pYzu6SEfTEy5BcxG59kjKVeDZ3 iTsF46OIj7SgxjpgnErmwCH5aVJ+vBGPB7iMgQo9kMIzFVINxzHnyq6kgg9KMXbU 4LfDPBL2mFZgwq4zj8PyNQIYl18C3AdmFauiiIqFITCL3lJGMv1M+KQL4rtneegl CQbuKxPxm5/B8budD3OaycfhTjF6+xbKqE/ZHw9RBTSbVjwOC3OAuYiTwVc5GxUn OVtx2sWHkWPTP1BEbh4V =9H4m -----END PGP SIGNATURE----- --EVF5PPMfhYS0aIcm--