From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Gonglei (Arei)" <arei.gonglei@huawei.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
"Huangweidong (C)" <weidong.huang@huawei.com>,
Markus Armbruster <armbru@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v4] pci-hotplug-old: avoid losing error message
Date: Tue, 30 Sep 2014 12:37:27 +0300 [thread overview]
Message-ID: <20140930093727.GA4655@redhat.com> (raw)
In-Reply-To: <33183CC9F5247A488A2544077AF1902086DDD5C0@SZXEMA503-MBS.china.huawei.com>
On Tue, Sep 30, 2014 at 08:23:05AM +0000, Gonglei (Arei) wrote:
> > Subject: Re: [Qemu-devel] [PATCH v4] pci-hotplug-old: avoid losing error
> > message
> >
> > Il 30/09/2014 10:12, Markus Armbruster ha scritto:
> > > error_report() is just fine here. qerror_report() is never necessary in
> > > HMP-only code. It makes a difference only in QMP context, and even
> > > there it should only be used in code that hasn't been converted to the
> > > Error API. For an example, see commit b1422f2.
> > >
> > > Eventually, qerror.h should just die. I've been chipping away at it
> > > when I have nothing better to do. Slow progress, better than no
> > > progress.
> > >
> > > Let's commit v4.
> >
> > Yeah, I've seen now that error_report ends up in monitor_vprintf.
> >
> > v4 is okay, sorry Gonglei.
> >
> > Paolo
>
> I'm fine, I'm a learner in some area. :)
>
> Who can merge this patch? Paolo, can you? Thanks!
>
> Best regards,
> -Gonglei
v4 is already applied in my tree, thanks everyone.
prev parent reply other threads:[~2014-09-30 9:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-18 13:06 [Qemu-devel] [PATCH v4] pci-hotplug-old: avoid losing error message arei.gonglei
2014-09-29 2:53 ` Gonglei (Arei)
2014-09-30 7:12 ` Paolo Bonzini
2014-09-30 7:17 ` Gonglei (Arei)
2014-09-30 8:12 ` Markus Armbruster
2014-09-30 8:18 ` Paolo Bonzini
2014-09-30 8:23 ` Gonglei (Arei)
2014-09-30 9:37 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140930093727.GA4655@redhat.com \
--to=mst@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=armbru@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=weidong.huang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).