From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57433)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1XYtp3-0006oZ-Tg
	for qemu-devel@nongnu.org; Tue, 30 Sep 2014 05:34:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1XYtox-0008L9-PD
	for qemu-devel@nongnu.org; Tue, 30 Sep 2014 05:34:17 -0400
Received: from mx1.redhat.com ([209.132.183.28]:37352)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1XYtox-0008KY-IK
	for qemu-devel@nongnu.org; Tue, 30 Sep 2014 05:34:11 -0400
Date: Tue, 30 Sep 2014 12:37:27 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20140930093727.GA4655@redhat.com>
References: <1411045577-1152-1-git-send-email-arei.gonglei@huawei.com>
	<542A57CE.9040000@redhat.com>
	<87wq8la5n1.fsf@blackfin.pond.sub.org>
	<542A674C.8070501@redhat.com>
	<33183CC9F5247A488A2544077AF1902086DDD5C0@SZXEMA503-MBS.china.huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <33183CC9F5247A488A2544077AF1902086DDD5C0@SZXEMA503-MBS.china.huawei.com>
Subject: Re: [Qemu-devel] [PATCH v4] pci-hotplug-old: avoid losing error
 message
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Gonglei (Arei)" <arei.gonglei@huawei.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, "Huangweidong (C)" <weidong.huang@huawei.com>, Markus Armbruster <armbru@redhat.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

On Tue, Sep 30, 2014 at 08:23:05AM +0000, Gonglei (Arei) wrote:
> > Subject: Re: [Qemu-devel] [PATCH v4] pci-hotplug-old: avoid losing error
> > message
> > 
> > Il 30/09/2014 10:12, Markus Armbruster ha scritto:
> > > error_report() is just fine here.  qerror_report() is never necessary in
> > > HMP-only code.  It makes a difference only in QMP context, and even
> > > there it should only be used in code that hasn't been converted to the
> > > Error API.  For an example, see commit b1422f2.
> > >
> > > Eventually, qerror.h should just die.  I've been chipping away at it
> > > when I have nothing better to do.  Slow progress, better than no
> > > progress.
> > >
> > > Let's commit v4.
> > 
> > Yeah, I've seen now that error_report ends up in monitor_vprintf.
> > 
> > v4 is okay, sorry Gonglei.
> > 
> > Paolo
> 
> I'm fine, I'm a learner in some area. :)
> 
> Who can merge this patch? Paolo, can you? Thanks!
> 
> Best regards,
> -Gonglei


v4 is already applied in my tree, thanks everyone.