From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: arei.gonglei@huawei.com
Cc: weidong.huang@huawei.com, mst@redhat.com, armbru@redhat.com,
luonengjun@huawei.com, agraf@suse.de, qemu-devel@nongnu.org,
borntraeger@de.ibm.com, stefanha@redhat.com, pbonzini@redhat.com,
peter.huangpeng@huawei.com, rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH v2 08/12] virtio-rng: fix virtio-rng child refcount in transports
Date: Tue, 30 Sep 2014 10:51:14 +0200 [thread overview]
Message-ID: <20140930105114.4910449d.cornelia.huck@de.ibm.com> (raw)
In-Reply-To: <1412057438-10004-9-git-send-email-arei.gonglei@huawei.com>
On Tue, 30 Sep 2014 14:10:34 +0800
<arei.gonglei@huawei.com> wrote:
> From: Gonglei <arei.gonglei@huawei.com>
>
> object_initialize() leaves the object with a refcount of 1.
> object_property_add_child() adds its own reference which is dropped
> again when the property is deleted.
>
> The upshot of this is that we always have a refcount >= 1. Upon hot
> unplug the virtio-rng child is not finalized!
>
> Drop our reference after the child property has been added to the
> parent.
>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> ---
> hw/s390x/s390-virtio-bus.c | 1 +
> hw/s390x/virtio-ccw.c | 1 +
> hw/virtio/virtio-pci.c | 1 +
> 3 files changed, 3 insertions(+)
Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>
next prev parent reply other threads:[~2014-09-30 8:51 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-30 6:10 [Qemu-devel] [PATCH v2 00/12] virtio: fix virtio child recount in transports arei.gonglei
2014-09-30 6:10 ` [Qemu-devel] [PATCH v2 01/12] virtio-net: use aliases instead of duplicate qdev properties arei.gonglei
2014-09-30 8:18 ` Cornelia Huck
2014-09-30 6:10 ` [Qemu-devel] [PATCH v2 02/12] virtio-net: fix virtio-net child refcount in transports arei.gonglei
2014-09-30 8:19 ` Cornelia Huck
2014-09-30 6:10 ` [Qemu-devel] [PATCH v2 03/12] virtio/vhost-scsi: use aliases instead of duplicate qdev properties arei.gonglei
2014-09-30 8:43 ` Cornelia Huck
2014-09-30 14:00 ` Cornelia Huck
2014-09-30 6:10 ` [Qemu-devel] [PATCH v2 04/12] virtio/vhost-scsi: fix virtio-scsi/vhost-scsi child refcount in transports arei.gonglei
2014-09-30 8:44 ` Cornelia Huck
2014-09-30 6:10 ` [Qemu-devel] [PATCH v2 05/12] virtio-serial: use aliases instead of duplicate qdev properties arei.gonglei
2014-09-30 8:46 ` Cornelia Huck
2014-09-30 6:10 ` [Qemu-devel] [PATCH v2 06/12] virtio-serial: fix virtio-serial child refcount in transports arei.gonglei
2014-09-30 8:47 ` Cornelia Huck
2014-09-30 6:10 ` [Qemu-devel] [PATCH v2 07/12] virtio-rng: use aliases instead of duplicate qdev properties arei.gonglei
2014-09-30 8:50 ` Cornelia Huck
2014-09-30 6:10 ` [Qemu-devel] [PATCH v2 08/12] virtio-rng: fix virtio-rng child refcount in transports arei.gonglei
2014-09-30 8:51 ` Cornelia Huck [this message]
2014-09-30 6:10 ` [Qemu-devel] [PATCH v2 09/12] virtio-balloon: fix virtio-balloon " arei.gonglei
2014-09-30 8:52 ` Cornelia Huck
2014-09-30 6:10 ` [Qemu-devel] [PATCH v2 10/12] virtio-9p: use aliases instead of duplicate qdev properties arei.gonglei
2014-09-30 6:10 ` [Qemu-devel] [PATCH v2 11/12] virtio-9p: fix virtio-9p child refcount in transports arei.gonglei
2014-09-30 6:10 ` [Qemu-devel] [PATCH v2 12/12] virtio: add a wrapper for virtio-backend initialization arei.gonglei
2014-09-30 9:04 ` Cornelia Huck
2014-09-30 9:10 ` Paolo Bonzini
2014-09-30 9:45 ` Gonglei (Arei)
2014-09-30 9:17 ` Paolo Bonzini
2014-09-30 9:35 ` Gonglei (Arei)
2014-09-30 10:58 ` Cornelia Huck
2014-09-30 10:51 ` Markus Armbruster
2014-09-30 8:02 ` [Qemu-devel] [PATCH v2 00/12] virtio: fix virtio child recount in transports Cornelia Huck
2014-09-30 8:06 ` Gonglei (Arei)
2014-09-30 8:41 ` Paolo Bonzini
2014-09-30 11:08 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140930105114.4910449d.cornelia.huck@de.ibm.com \
--to=cornelia.huck@de.ibm.com \
--cc=agraf@suse.de \
--cc=arei.gonglei@huawei.com \
--cc=armbru@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=luonengjun@huawei.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.huangpeng@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=stefanha@redhat.com \
--cc=weidong.huang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).