From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48193) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYvFB-0006ib-ED for qemu-devel@nongnu.org; Tue, 30 Sep 2014 07:05:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XYvF6-00006p-Ie for qemu-devel@nongnu.org; Tue, 30 Sep 2014 07:05:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:12491) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYvF6-00006Y-AA for qemu-devel@nongnu.org; Tue, 30 Sep 2014 07:05:16 -0400 Date: Tue, 30 Sep 2014 14:08:26 +0300 From: "Michael S. Tsirkin" Message-ID: <20140930110826.GC7089@redhat.com> References: <1412057438-10004-1-git-send-email-arei.gonglei@huawei.com> <542A6CA7.6040108@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <542A6CA7.6040108@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 00/12] virtio: fix virtio child recount in transports List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: agraf@suse.de, weidong.huang@huawei.com, armbru@redhat.com, luonengjun@huawei.com, peter.huangpeng@huawei.com, qemu-devel@nongnu.org, borntraeger@de.ibm.com, arei.gonglei@huawei.com, stefanha@redhat.com, cornelia.huck@de.ibm.com, rth@twiddle.net On Tue, Sep 30, 2014 at 10:41:11AM +0200, Paolo Bonzini wrote: > Il 30/09/2014 08:10, arei.gonglei@huawei.com ha scritto: > > From: Gonglei > > > > virtio-$device-{pci, s390, ccw} all duplicate the > > qdev properties of their virtio child. This approach does > > not work well with string or pointer properties since we > > must be careful about leaking or double-freeing them. > > > > Use the QOM alias property to forward property accesses to the > > VirtIORNG child. This way no duplication is necessary. > > > > For their child, object_initialize() leaves the object with a refcount of 1. > > object_property_add_child() adds its own reference which is dropped > > again when the property is deleted. > > > > The upshot of this is that we always have a refcount >= 1. Upon hot > > unplug the virtio-$device child is not finalized! > > > > Drop our reference after the child property has been added to the > > parent. > > > > Changs since v1: > > - add the same handling for virtio-9p-pci device in PATCH 10 and PATCH 11. > > - add a wrapper function for better code sharing > > in PATCH 12 (Cornelia/Michael/Paolo) > > I would like to take these patches through the SCSI tree, because of a > small conflict with virtio-scsi dataplane. Any objections? > > Paolo Fine with me. Reviewed-by: Michael S. Tsirkin