From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54187) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYvld-00032X-7Q for qemu-devel@nongnu.org; Tue, 30 Sep 2014 07:38:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XYvlX-0008Lh-H8 for qemu-devel@nongnu.org; Tue, 30 Sep 2014 07:38:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55185) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYvlX-0008Kq-AJ for qemu-devel@nongnu.org; Tue, 30 Sep 2014 07:38:47 -0400 Date: Tue, 30 Sep 2014 14:42:00 +0300 From: "Michael S. Tsirkin" Message-ID: <20140930114200.GF7089@redhat.com> References: <1412046159-5144-1-git-send-email-arei.gonglei@huawei.com> <1412046159-5144-2-git-send-email-arei.gonglei@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1412046159-5144-2-git-send-email-arei.gonglei@huawei.com> Subject: Re: [Qemu-devel] [PATCH v4 1/5] qdev: add description field in PropertyInfo struct List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: arei.gonglei@huawei.com Cc: weidong.huang@huawei.com, aliguori@amazon.com, armbru@redhat.com, luonengjun@huawei.com, peter.huangpeng@huawei.com, qemu-devel@nongnu.org, stefanha@redhat.com, pbonzini@redhat.com, lcapitulino@redhat.com, afaerber@suse.de On Tue, Sep 30, 2014 at 11:02:35AM +0800, arei.gonglei@huawei.com wrote: > @@ -552,6 +556,7 @@ static int print_pci_devfn(DeviceState *dev, Property *prop, char *dest, > PropertyInfo qdev_prop_pci_devfn = { > .name = "int32", Is this name used anywhere? It seems wrong ... > .legacy_name = "pci-devfn", > + .description = "Slot and function number, example: 06.0", In fact, .0 can be omitted. So please make this: Slot and optional function number, examples: 06.0 or 06. > .print = print_pci_devfn, > .get = get_int32, > .set = set_pci_devfn,