From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38916) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYwll-000342-Rk for qemu-devel@nongnu.org; Tue, 30 Sep 2014 08:43:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XYwlg-0007jc-W6 for qemu-devel@nongnu.org; Tue, 30 Sep 2014 08:43:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:9241) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYwlg-0007j3-JG for qemu-devel@nongnu.org; Tue, 30 Sep 2014 08:43:00 -0400 Date: Tue, 30 Sep 2014 15:46:15 +0300 From: "Michael S. Tsirkin" Message-ID: <20140930124615.GA2012@redhat.com> References: <1412071886-10192-1-git-send-email-arei.gonglei@huawei.com> <1412071886-10192-4-git-send-email-arei.gonglei@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1412071886-10192-4-git-send-email-arei.gonglei@huawei.com> Subject: Re: [Qemu-devel] [PATCH v4 3/3] pcie: remove confused comments List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: arei.gonglei@huawei.com Cc: peter.crosthwaite@xilinx.com, knut.omang@oracle.com, weidong.huang@huawei.com, marcel.a@redhat.com, armbru@redhat.com, luonengjun@huawei.com, qemu-devel@nongnu.org, peter.huangpeng@huawei.com, imammedo@redhat.com, pbonzini@redhat.com, afaerber@suse.de On Tue, Sep 30, 2014 at 06:11:26PM +0800, arei.gonglei@huawei.com wrote: > From: Gonglei > > The below functions is not allocation functions, but > find helper function. The only allocation function is > pcie_add_capability(), but its argument names is not the > same with the comments. So remove this comments which > make people confused. > > Signed-off-by: Gonglei The comment applies to all functions below it. Maybe simply replace s/capability allocation/capability list management/? Also pls make this a separate patch, does not belong in this series. > --- > hw/pci/pcie.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c > index b82211a..f2b9d5d 100644 > --- a/hw/pci/pcie.c > +++ b/hw/pci/pcie.c > @@ -528,14 +528,6 @@ bool pcie_cap_is_arifwd_enabled(const PCIDevice *dev) > PCI_EXP_DEVCTL2_ARI; > } > > -/************************************************************************** > - * pci express extended capability allocation functions > - * uint16_t ext_cap_id (16 bit) > - * uint8_t cap_ver (4 bit) > - * uint16_t cap_offset (12 bit) > - * uint16_t ext_cap_size > - */ > - > static uint16_t pcie_find_capability_list(PCIDevice *dev, uint16_t cap_id, > uint16_t *prev_p) > { > -- > 1.7.12.4 >