From: "Michael S. Tsirkin" <mst@redhat.com>
To: arei.gonglei@huawei.com
Cc: weidong.huang@huawei.com, aliguori@amazon.com, armbru@redhat.com,
luonengjun@huawei.com, peter.huangpeng@huawei.com,
qemu-devel@nongnu.org, stefanha@redhat.com, pbonzini@redhat.com,
lcapitulino@redhat.com, afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH v4 0/5] add description field in ObjectProperty and PropertyInfo struct
Date: Tue, 30 Sep 2014 16:32:10 +0300 [thread overview]
Message-ID: <20140930133210.GB2999@redhat.com> (raw)
In-Reply-To: <1412046159-5144-1-git-send-email-arei.gonglei@huawei.com>
On Tue, Sep 30, 2014 at 11:02:34AM +0800, arei.gonglei@huawei.com wrote:
> From: Gonglei <arei.gonglei@huawei.com>
>
> This patch series based on qom-next tree:
> https://github.com/afaerber/qemu-cpu/commits/qom-next
>
> Add a description field in both ObjectProperty and PropertyInfo struct.
> The descriptions can serve as documentation in the code,
> and they can be used to provide better help.
I'm fine with merging this as is, and adding improvements
on top.
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
next prev parent reply other threads:[~2014-09-30 13:29 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-30 3:02 [Qemu-devel] [PATCH v4 0/5] add description field in ObjectProperty and PropertyInfo struct arei.gonglei
2014-09-30 3:02 ` [Qemu-devel] [PATCH v4 1/5] qdev: add description field in " arei.gonglei
2014-09-30 11:42 ` Michael S. Tsirkin
2014-09-30 13:14 ` Gonglei
2014-09-30 13:33 ` Michael S. Tsirkin
2014-09-30 13:36 ` Paolo Bonzini
2014-09-30 13:55 ` Michael S. Tsirkin
2014-09-30 13:53 ` Paolo Bonzini
2014-09-30 14:01 ` Michael S. Tsirkin
2014-09-30 14:02 ` Paolo Bonzini
2014-10-01 4:05 ` Gonglei
2014-09-30 14:01 ` Gonglei
2014-09-30 3:02 ` [Qemu-devel] [PATCH v4 2/5] qom: add description field in ObjectProperty struct arei.gonglei
2014-09-30 11:48 ` Michael S. Tsirkin
2014-09-30 13:18 ` Gonglei
2014-09-30 3:02 ` [Qemu-devel] [PATCH v4 3/5] qdev: set the object property's description to the qdev property's arei.gonglei
2014-09-30 3:02 ` [Qemu-devel] [PATCH v4 4/5] qmp: print descriptions of object properties arei.gonglei
2014-09-30 15:38 ` Eric Blake
2014-09-30 3:02 ` [Qemu-devel] [PATCH v4 5/5] qdev: drop legacy_name from qdev properties arei.gonglei
2014-09-30 11:43 ` Michael S. Tsirkin
2014-09-30 13:15 ` Gonglei
2014-09-30 8:54 ` [Qemu-devel] [PATCH v4 0/5] add description field in ObjectProperty and PropertyInfo struct Paolo Bonzini
2014-09-30 11:35 ` Michael S. Tsirkin
2014-09-30 11:53 ` Paolo Bonzini
2014-09-30 12:09 ` Markus Armbruster
2014-09-30 13:05 ` Gonglei
2014-09-30 13:32 ` Michael S. Tsirkin [this message]
2014-09-30 14:05 ` Gonglei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140930133210.GB2999@redhat.com \
--to=mst@redhat.com \
--cc=afaerber@suse.de \
--cc=aliguori@amazon.com \
--cc=arei.gonglei@huawei.com \
--cc=armbru@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=luonengjun@huawei.com \
--cc=pbonzini@redhat.com \
--cc=peter.huangpeng@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=weidong.huang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).