From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47544) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYxUS-0002oO-9g for qemu-devel@nongnu.org; Tue, 30 Sep 2014 09:29:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XYxUN-0002as-Se for qemu-devel@nongnu.org; Tue, 30 Sep 2014 09:29:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:6516) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYxUN-0002a7-Ld for qemu-devel@nongnu.org; Tue, 30 Sep 2014 09:29:11 -0400 Date: Tue, 30 Sep 2014 16:32:10 +0300 From: "Michael S. Tsirkin" Message-ID: <20140930133210.GB2999@redhat.com> References: <1412046159-5144-1-git-send-email-arei.gonglei@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1412046159-5144-1-git-send-email-arei.gonglei@huawei.com> Subject: Re: [Qemu-devel] [PATCH v4 0/5] add description field in ObjectProperty and PropertyInfo struct List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: arei.gonglei@huawei.com Cc: weidong.huang@huawei.com, aliguori@amazon.com, armbru@redhat.com, luonengjun@huawei.com, peter.huangpeng@huawei.com, qemu-devel@nongnu.org, stefanha@redhat.com, pbonzini@redhat.com, lcapitulino@redhat.com, afaerber@suse.de On Tue, Sep 30, 2014 at 11:02:34AM +0800, arei.gonglei@huawei.com wrote: > From: Gonglei > > This patch series based on qom-next tree: > https://github.com/afaerber/qemu-cpu/commits/qom-next > > Add a description field in both ObjectProperty and PropertyInfo struct. > The descriptions can serve as documentation in the code, > and they can be used to provide better help. I'm fine with merging this as is, and adding improvements on top. Reviewed-by: Michael S. Tsirkin