From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54014) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYxqW-0001fK-T6 for qemu-devel@nongnu.org; Tue, 30 Sep 2014 09:52:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XYxqR-0000es-Fi for qemu-devel@nongnu.org; Tue, 30 Sep 2014 09:52:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:14852) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYxqR-0000ec-8l for qemu-devel@nongnu.org; Tue, 30 Sep 2014 09:51:59 -0400 Date: Tue, 30 Sep 2014 16:55:08 +0300 From: "Michael S. Tsirkin" Message-ID: <20140930135508.GA3560@redhat.com> References: <1412046159-5144-1-git-send-email-arei.gonglei@huawei.com> <1412046159-5144-2-git-send-email-arei.gonglei@huawei.com> <20140930114200.GF7089@redhat.com> <20140930133337.GC2999@redhat.com> <542AB1D6.4010900@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <542AB1D6.4010900@redhat.com> Subject: Re: [Qemu-devel] [PATCH v4 1/5] qdev: add description field in PropertyInfo struct List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: weidong.huang@huawei.com, stefanha@redhat.com, qemu-devel@nongnu.org, luonengjun@huawei.com, armbru@redhat.com, peter.huangpeng@huawei.com, arei.gonglei@huawei.com, aliguori@amazon.com, lcapitulino@redhat.com, afaerber@suse.de, Gonglei On Tue, Sep 30, 2014 at 03:36:22PM +0200, Paolo Bonzini wrote: > Il 30/09/2014 15:33, Michael S. Tsirkin ha scritto: > > > > > > > The Propertyinfo.name is used to the qdev property's type, please see PATCH 4: > > > > > > - info->type = g_strdup(prop->info->legacy_name ?: prop->info->name); > > > + info->type = g_strdup(prop->info->name); > > > > I would say this one is more a string than an int. > > At the QOM level it is an int, even though it secondarily accepts a > string in "DD.F" format. > > Paolo That's the only way to specify a function, isn't it? Maybe it's not a good idea to expose the QOM type in this case. -- MST