From: "Benoît Canet" <benoit.canet@nodalink.com>
To: Jeff Cody <jcody@redhat.com>
Cc: kwolf@redhat.com, famz@redhat.com, stefanha@redhat.com,
qemu-devel@nongnu.org, "Benoît Canet" <benoit.canet@nodalink.com>
Subject: Re: [Qemu-devel] [PATCH v2 2/2] block: Make op blockers recursive
Date: Wed, 1 Oct 2014 04:59:24 +0000 [thread overview]
Message-ID: <20141001045924.GA5378@nodalink.com> (raw)
In-Reply-To: <20141001043842.GA12347@localhost.localdomain>
>
> Seems like these new functions would be better named '.bdrv_op_block'
> and '.bdrv_op_unblock'? That way, recursive or not, it is clear block
> drivers can implement whatever blocking is appropriate for themselves.
>
> > QLIST_ENTRY(BlockDriver) list;
> > };
Hi,
Thanks a lot for review.
I will mull this and respond in the begining of the afternoon.
Best regards
Benoît
next prev parent reply other threads:[~2014-10-01 4:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-22 19:00 [Qemu-devel] [PATCH v2 0/2] Recursive op blockers Benoît Canet
2014-09-22 19:00 ` [Qemu-devel] [PATCH v2 1/2] block: Rename BLOCK_OP_TYPE_REPLACE to BLOCK_OP_TYPE_MIRROR_REPLACE Benoît Canet
2014-09-22 19:00 ` [Qemu-devel] [PATCH v2 2/2] block: Make op blockers recursive Benoît Canet
2014-10-01 4:38 ` Jeff Cody
2014-10-01 4:59 ` Benoît Canet [this message]
2014-10-01 9:29 ` Benoît Canet
2014-10-01 15:19 ` Jeff Cody
2014-10-01 15:42 ` Benoît Canet
2014-09-29 16:08 ` [Qemu-devel] [PATCH v2 0/2] Recursive op blockers Benoît Canet
-- strict thread matches above, loose matches on Subject: below --
2014-09-22 12:40 Benoît Canet
2014-09-22 12:40 ` [Qemu-devel] [PATCH v2 2/2] block: Make op blockers recursive Benoît Canet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141001045924.GA5378@nodalink.com \
--to=benoit.canet@nodalink.com \
--cc=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).