From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41041) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XZbWE-0007O6-OU for qemu-devel@nongnu.org; Thu, 02 Oct 2014 04:13:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XZbW9-0000l0-SZ for qemu-devel@nongnu.org; Thu, 02 Oct 2014 04:13:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59981) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XZbW9-0000kw-Ko for qemu-devel@nongnu.org; Thu, 02 Oct 2014 04:13:41 -0400 Date: Thu, 2 Oct 2014 11:17:07 +0300 From: "Michael S. Tsirkin" Message-ID: <20141002081707.GC19369@redhat.com> References: <592b4a2a2b00e21470bec1a2ecf259a64eb285b2.1406703720.git.jan.kiszka@siemens.com> <20140730085732.GA14263@redhat.com> <53D8B6B4.5070302@redhat.com> <87a97rnlfb.fsf@blackfin.pond.sub.org> <20140902151125.16792.32360@loki> <542CFE6D.9090707@siemens.com> <20141002080344.GB19039@redhat.com> <542D0752.3090300@siemens.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <542D0752.3090300@siemens.com> Subject: Re: [Qemu-devel] [PATCH 1/3] pc: Fix disabling of vapic for compat PC models List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: qemu-devel , Paolo Bonzini , Michael Roth , Markus Armbruster On Thu, Oct 02, 2014 at 10:05:38AM +0200, Jan Kiszka wrote: > On 2014-10-02 10:03, Michael S. Tsirkin wrote: > > On Thu, Oct 02, 2014 at 09:27:41AM +0200, Jan Kiszka wrote: > >> On 2014-09-02 17:11, Michael Roth wrote: > >>> Quoting Markus Armbruster (2014-07-30 06:19:36) > >>>> Paolo Bonzini writes: > >>>> > >>>>> Il 30/07/2014 10:57, Michael S. Tsirkin ha scritto: > >>>>>> On Wed, Jul 30, 2014 at 09:01:59AM +0200, Jan Kiszka wrote: > >>>>>>> We used to be able to address both the QEMU and the KVM APIC via "apic". > >>>>>>> This doesn't work anymore. So we need to use their parent class to turn > >>>>>>> off the vapic on machines that should not expose them. > >>>>>>> > >>>>>>> Signed-off-by: Jan Kiszka > >>>>>> > >>>>>> > >>>>>> > >>>>>> OK so this is intended for 2.2? > >>>> > >>>> If yes, we should cc: qemu-stable. > >>> > >>> Ping for stable 2.1.1, freeze is on Wednesday > >> > >> Lost track of this: was I supposed to provide anything different, or did > >> this just fall under the table? > >> > >> Jan > > > > Yes, I think Michael expected an ACK for stable. > > Oh well. > > Would you like me to apply as is, or to rework this to avoid duplication > > of string names? > > I don't mind, but I wouldn't refuse if you want to take care of the issue. > > Jan I've applied as-is for now, thanks. I think the use of strings in compat machine types is too fragile, we should have a header with type names, and reuse it through macros, but apic is not unique here. > -- > Siemens AG, Corporate Technology, CT RTC ITP SES-DE > Corporate Competence Center Embedded Linux