From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56984) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XZf5j-0007zG-90 for qemu-devel@nongnu.org; Thu, 02 Oct 2014 08:02:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XZf5c-0000yh-Du for qemu-devel@nongnu.org; Thu, 02 Oct 2014 08:02:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:31545) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XZf5c-0000yR-7X for qemu-devel@nongnu.org; Thu, 02 Oct 2014 08:02:32 -0400 Date: Thu, 2 Oct 2014 13:02:25 +0100 From: Stefan Hajnoczi Message-ID: <20141002120225.GA29693@stefanha-thinkpad.redhat.com> References: <1409847879-9783-1-git-send-email-marc.mari.barcelo@gmail.com> <1409847879-9783-2-git-send-email-marc.mari.barcelo@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="liOOAslEiF7prFVr" Content-Disposition: inline In-Reply-To: <1409847879-9783-2-git-send-email-marc.mari.barcelo@gmail.com> Subject: Re: [Qemu-devel] [PATCH 1/3] libqos: Remove PCI assumptions in virtio driver List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marc =?iso-8859-1?Q?Mar=ED?= Cc: Paolo Bonzini , qemu-devel@nongnu.org --liOOAslEiF7prFVr Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 04, 2014 at 06:24:37PM +0200, Marc Mar=ED wrote: > @@ -60,25 +60,25 @@ static void qvirtio_pci_assign_device(QVirtioDevice *= d, void *data) > *vpcidev =3D (QVirtioPCIDevice *)d; > } > =20 > -static uint8_t qvirtio_pci_config_readb(QVirtioDevice *d, void *addr) > +static uint8_t qvirtio_pci_config_readb(QVirtioDevice *d, uint64_t addr) > { > QVirtioPCIDevice *dev =3D (QVirtioPCIDevice *)d; > - return qpci_io_readb(dev->pdev, addr); > + return qpci_io_readb(dev->pdev, (void *)addr); You do not need casts in C for void* to any pointer type or any pointer type to void*. Please drop them. > diff --git a/tests/libqos/virtio-pci.h b/tests/libqos/virtio-pci.h > index 883f7ff..8f0e52a 100644 > --- a/tests/libqos/virtio-pci.h > +++ b/tests/libqos/virtio-pci.h > @@ -13,18 +13,18 @@ > #include "libqos/virtio.h" > #include "libqos/pci.h" > =20 > -#define QVIRTIO_DEVICE_FEATURES 0x00 > -#define QVIRTIO_GUEST_FEATURES 0x04 > -#define QVIRTIO_QUEUE_ADDRESS 0x08 > -#define QVIRTIO_QUEUE_SIZE 0x0C > -#define QVIRTIO_QUEUE_SELECT 0x0E > -#define QVIRTIO_QUEUE_NOTIFY 0x10 > -#define QVIRTIO_DEVICE_STATUS 0x12 > -#define QVIRTIO_ISR_STATUS 0x13 > -#define QVIRTIO_MSIX_CONF_VECTOR 0x14 > -#define QVIRTIO_MSIX_QUEUE_VECTOR 0x16 > -#define QVIRTIO_DEVICE_SPECIFIC_MSIX 0x18 > -#define QVIRTIO_DEVICE_SPECIFIC_NO_MSIX 0x14 > +#define QVIRTIO_PCI_DEVICE_FEATURES 0x00 > +#define QVIRTIO_PCI_GUEST_FEATURES 0x04 > +#define QVIRTIO_PCI_QUEUE_ADDRESS 0x08 > +#define QVIRTIO_PCI_QUEUE_SIZE 0x0C > +#define QVIRTIO_PCI_QUEUE_SELECT 0x0E > +#define QVIRTIO_PCI_QUEUE_NOTIFY 0x10 > +#define QVIRTIO_PCI_DEVICE_STATUS 0x12 > +#define QVIRTIO_PCI_ISR_STATUS 0x13 > +#define QVIRTIO_PCI_MSIX_CONF_VECTOR 0x14 > +#define QVIRTIO_PCI_MSIX_QUEUE_VECTOR 0x16 > +#define QVIRTIO_PCI_DEVICE_SPECIFIC_MSIX 0x18 > +#define QVIRTIO_PCI_DEVICE_SPECIFIC_NO_MSIX 0x14 This is a nice isolated change that could be made in a separate commit =66rom the void* -> uint64_t change. It's a matter of style but makes code review easier since it is harder to review a patch that is performing multiple changes at once. --liOOAslEiF7prFVr Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJULT7RAAoJEJykq7OBq3PIa/YH/0SczsQNwKiCg/TTzLiU2MM9 Qq/anPSVJaekXahsXWx2bks0fvkvbxhO+U8qlvBlKrjCAk56VB4ffZExdnJEE3dJ F0+NhopreCMnXrmVuP45peYqADr+wytfRrWZH2ZI67f0TkcIEJlxkaZipf1MIao6 R7eTuuDs/lGq63/vdyiYejG566l1FGRjUQ3ZTFiCV1s+KlAbPSCCPHlKzvs5zwq0 wPXsle+GlvChAIwsNq3SU2LuwIo1g0loOoGG3zx9NpqYhSPJz5La9JvPdi75VlOk pX3SY1rjAxGdOoMHDjaHN2cCMGexqQQB8Jw0qyWx5+UArhvyHZMca7fS87Ty2LQ= =+m+G -----END PGP SIGNATURE----- --liOOAslEiF7prFVr--