From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58697)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1XZfCj-0003OA-Gi
	for qemu-devel@nongnu.org; Thu, 02 Oct 2014 08:09:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1XZfCc-0003Zy-LA
	for qemu-devel@nongnu.org; Thu, 02 Oct 2014 08:09:53 -0400
Received: from mx1.redhat.com ([209.132.183.28]:40968)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1XZfCc-0003Zs-Cx
	for qemu-devel@nongnu.org; Thu, 02 Oct 2014 08:09:46 -0400
Date: Thu, 2 Oct 2014 13:09:42 +0100
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20141002120942.GB29693@stefanha-thinkpad.redhat.com>
References: <1409847879-9783-1-git-send-email-marc.mari.barcelo@gmail.com>
	<1409847879-9783-3-git-send-email-marc.mari.barcelo@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="bCsyhTFzCvuiizWE"
Content-Disposition: inline
In-Reply-To: <1409847879-9783-3-git-send-email-marc.mari.barcelo@gmail.com>
Subject: Re: [Qemu-devel] [PATCH 2/3] libqos: Add malloc generic
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Marc =?iso-8859-1?Q?Mar=ED?= <marc.mari.barcelo@gmail.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org


--bCsyhTFzCvuiizWE
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Sep 04, 2014 at 06:24:38PM +0200, Marc Mar=ED wrote:
> This malloc is a basic interface implementation that works for any platfo=
rm.
> It should be replaced in the future for a real malloc implementation for =
each
> of the platforms.
>=20
> Signed-off-by: Marc Mar=ED <marc.mari.barcelo@gmail.com>
> ---
>  tests/libqos/malloc-generic.c |   54 +++++++++++++++++++++++++++++++++++=
++++++
>  tests/libqos/malloc-generic.h |   18 ++++++++++++++
>  2 files changed, 72 insertions(+)
>  create mode 100644 tests/libqos/malloc-generic.c
>  create mode 100644 tests/libqos/malloc-generic.h

malloc-pc.c is the "real malloc implementation" you speak of.  Just
pc_alloc_init_flags() needs to be tweaked for the memory map of a
particular platform.

I'm not sure I see the point of this patch.  Instead we should reuse
malloc-pc.c.

--bCsyhTFzCvuiizWE
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJULUCGAAoJEJykq7OBq3PI7A4H/0UxT75Cga/oN6ulmq7bz4x3
dtvykCbB+Bi21HTnhvDLzbvzX2DR5RtnrEqCEX2X8qZkEBtu5bKTRV9KtY3PjPkg
TPSkz7qubJ7GOwGCn8xA0a1VfbeZUxB4yrv6qBY8o2l3QwJkxDJF4LmbU/rAdGu5
d/3ht9TotJa1cleendyehS4d7rfx5KEVPUv/ScYvS85xR1IViyJnwCE7ncKX3+O/
EEAKgJgs5Z42GbwA7ztOhfZJbWy+iVyEiBTIM7j9nlQFQi3oFZveMdFU1GIA2MUD
jVV+jc+qRoAV5B8wsTX35UIl5oDeLGM0Dt8I3fqEyM8iyyGzErnEu1BHSUnl63w=
=rkXE
-----END PGP SIGNATURE-----

--bCsyhTFzCvuiizWE--