qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Gal Hammer <ghammer@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	qemu-devel@nongnu.org, Igor Mammedov <imammedo@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/2 V5] Virtual Machine Generation ID
Date: Thu, 2 Oct 2014 15:16:24 +0300	[thread overview]
Message-ID: <20141002121624.GA25560@redhat.com> (raw)
In-Reply-To: <20141002121253.GB25373@redhat.com>

On Thu, Oct 02, 2014 at 03:12:53PM +0300, Michael S. Tsirkin wrote:
> On Wed, Sep 17, 2014 at 02:39:50PM +0300, Gal Hammer wrote:
> > Hi,
> > 
> > A two parts patch to add a QEmu support for Microsoft's Virtual Machine
> > Generation ID device.
> > 
> > The first one add a new ACPI directive which allow to use a 16-bytes
> > buffer in an ACPI table. This buffer is for storing the VM's UUID.
> > 
> > The second is the ACPI tables changes and the actual device.
> > 
> > Your comment are welcomed.
> > 
> > Thanks,
> > 
> >     Gal.
> 
> I applied this, thanks!

Ooops wrong thread :(

I will review this now though.

> > V5: - include the pre-compiled ASL file
> >     - remove an empty line at end of files.
> > 
> > V4: - Move device's description to SSDT table (dynamic build).
> > 
> > V3: - Fix a typo in error message string.
> >     - Move device's description from DSDT back to SSDT table.
> > 
> > V2: - Remove "-uuid" command line parameter.
> >     - Move device's description from SSDT to DSDT table.
> >     - Add new "vmgenid" sysbus device.
> > 
> > Gal Hammer (2):
> >   i386: Add an ACPI_EXTRACT_NAME_BUFFER16 directive.
> >   i386: Add a Virtual Machine Generation ID device.
> > 
> >  default-configs/i386-softmmu.mak   |   1 +
> >  default-configs/x86_64-softmmu.mak |   1 +
> >  hw/i386/Makefile.objs              |   2 +-
> >  hw/i386/acpi-build.c               |  39 +++++++
> >  hw/i386/ssdt-vmgenid.dsl           |  63 ++++++++++++
> >  hw/i386/ssdt-vmgenid.hex.generated | 206 +++++++++++++++++++++++++++++++++++++
> >  hw/misc/Makefile.objs              |   1 +
> >  hw/misc/vmgenid.c                  |  84 +++++++++++++++
> >  include/hw/i386/pc.h               |   3 +
> >  scripts/acpi_extract.py            |  23 +++--
> >  10 files changed, 413 insertions(+), 10 deletions(-)
> >  create mode 100644 hw/i386/ssdt-vmgenid.dsl
> >  create mode 100644 hw/i386/ssdt-vmgenid.hex.generated
> >  create mode 100644 hw/misc/vmgenid.c
> > 
> > -- 
> > 1.9.3
> > 

  reply	other threads:[~2014-10-02 12:13 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-17 11:39 [Qemu-devel] [PATCH 0/2 V5] Virtual Machine Generation ID Gal Hammer
2014-09-17 11:39 ` [Qemu-devel] [PATCH 1/2] i386: Add an ACPI_EXTRACT_NAME_BUFFER16 directive Gal Hammer
2014-10-02 12:20   ` Michael S. Tsirkin
2014-09-17 11:39 ` [Qemu-devel] [PATCH 2/2] i386: Add a Virtual Machine Generation ID device Gal Hammer
2014-10-02 12:49   ` Michael S. Tsirkin
2014-10-02 13:14     ` Gal Hammer
2014-10-02 13:30       ` Michael S. Tsirkin
2014-10-01  8:58 ` [Qemu-devel] [PATCH 0/2 V5] Virtual Machine Generation ID Markus Armbruster
2014-10-02  8:32   ` Gal Hammer
2014-10-02  8:46     ` Michael S. Tsirkin
2014-10-02 12:12 ` Michael S. Tsirkin
2014-10-02 12:16   ` Michael S. Tsirkin [this message]
2014-10-06  9:06 ` Daniel P. Berrange
2014-10-06 12:48   ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141002121624.GA25560@redhat.com \
    --to=mst@redhat.com \
    --cc=ghammer@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).