From: Stefan Hajnoczi <stefanha@redhat.com>
To: "Marc Marí" <marc.mari.barcelo@gmail.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 3/3] libqos: Add virtio MMIO support
Date: Thu, 2 Oct 2014 13:24:57 +0100 [thread overview]
Message-ID: <20141002122457.GC29693@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1409847879-9783-4-git-send-email-marc.mari.barcelo@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 649 bytes --]
On Thu, Sep 04, 2014 at 06:24:39PM +0200, Marc Marí wrote:
> +QVirtioMMIODevice *qvirtio_mmio_init_device(uint64_t addr, uint32_t page_size)
> +{
> + QVirtioMMIODevice *dev;
> + union { uint32_t magic; char bytes[5]; } magic_value;
> + dev = g_malloc0(sizeof(*dev));
> + magic_value.bytes[4] = '\0';
> +
> + magic_value.magic = readl(addr + QVIRTIO_MMIO_MAGIC_VALUE);
> + g_assert_cmpstr(magic_value.bytes, ==, "virt");
Endianness trouble here.
Please do what the Linux virtio_mmio driver does:
magic = readl(vm_dev->base + VIRTIO_MMIO_MAGIC_VALUE);
if (magic != ('v' | 'i' << 8 | 'r' << 16 | 't' << 24)) {
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2014-10-02 12:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-04 16:24 [Qemu-devel] [PATCH 0/3] Virtio MMIO libqos driver Marc Marí
2014-09-04 16:24 ` [Qemu-devel] [PATCH 1/3] libqos: Remove PCI assumptions in virtio driver Marc Marí
2014-10-02 12:02 ` Stefan Hajnoczi
2014-10-03 11:53 ` Marc Marí
2014-10-06 9:02 ` Stefan Hajnoczi
2014-09-04 16:24 ` [Qemu-devel] [PATCH 2/3] libqos: Add malloc generic Marc Marí
2014-10-02 12:09 ` Stefan Hajnoczi
2014-09-04 16:24 ` [Qemu-devel] [PATCH 3/3] libqos: Add virtio MMIO support Marc Marí
2014-10-02 12:24 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141002122457.GC29693@stefanha-thinkpad.redhat.com \
--to=stefanha@redhat.com \
--cc=marc.mari.barcelo@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).