From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33515) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XZfRU-00039h-KR for qemu-devel@nongnu.org; Thu, 02 Oct 2014 08:25:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XZfRO-00007n-HM for qemu-devel@nongnu.org; Thu, 02 Oct 2014 08:25:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:27961) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XZfRO-000072-B5 for qemu-devel@nongnu.org; Thu, 02 Oct 2014 08:25:02 -0400 Date: Thu, 2 Oct 2014 13:24:57 +0100 From: Stefan Hajnoczi Message-ID: <20141002122457.GC29693@stefanha-thinkpad.redhat.com> References: <1409847879-9783-1-git-send-email-marc.mari.barcelo@gmail.com> <1409847879-9783-4-git-send-email-marc.mari.barcelo@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="zCKi3GIZzVBPywwA" Content-Disposition: inline In-Reply-To: <1409847879-9783-4-git-send-email-marc.mari.barcelo@gmail.com> Subject: Re: [Qemu-devel] [PATCH 3/3] libqos: Add virtio MMIO support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marc =?iso-8859-1?Q?Mar=ED?= Cc: Paolo Bonzini , qemu-devel@nongnu.org --zCKi3GIZzVBPywwA Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 04, 2014 at 06:24:39PM +0200, Marc Mar=ED wrote: > +QVirtioMMIODevice *qvirtio_mmio_init_device(uint64_t addr, uint32_t page= _size) > +{ > + QVirtioMMIODevice *dev; > + union { uint32_t magic; char bytes[5]; } magic_value; > + dev =3D g_malloc0(sizeof(*dev)); > + magic_value.bytes[4] =3D '\0'; > + > + magic_value.magic =3D readl(addr + QVIRTIO_MMIO_MAGIC_VALUE); > + g_assert_cmpstr(magic_value.bytes, =3D=3D, "virt"); Endianness trouble here. Please do what the Linux virtio_mmio driver does: magic =3D readl(vm_dev->base + VIRTIO_MMIO_MAGIC_VALUE); if (magic !=3D ('v' | 'i' << 8 | 'r' << 16 | 't' << 24)) { --zCKi3GIZzVBPywwA Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJULUQZAAoJEJykq7OBq3PIxI0IALUt2lUgnXH0dpNBg+VBXIxt gMmptGw1aO6G7e64lzFFX2NyzqR+gTWQrlMXz+LprqvIEi6MuiNg4v4NcDvLjpWq wMrI1qCtyXtnaBpveMft+0uQ6SCq4w/nVctiYvdA3y1Atvf8qZ0Anzu0zz2Sj3KZ nV/0/rEen+PUoMdT/eMYdQfbwgD/FTdHQ/erXJBfs8HtVEJ0i655iCkBYprKcbgI kqUH/q0klchJD/PQ9lOScaMKQPfS9dzsaKYvjUkhg6R8WqrrM5t++jOEmLcgrL/i WBV+5sDPEtXCKs/E5jcQVXxAgrqtq+Ny1XPsznZPmmAga7G4N1U1IygyoUGv2KU= =TU7m -----END PGP SIGNATURE----- --zCKi3GIZzVBPywwA--