From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39194)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1XZfqs-0005Zj-3A
	for qemu-devel@nongnu.org; Thu, 02 Oct 2014 08:51:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1XZfqn-0000dK-BY
	for qemu-devel@nongnu.org; Thu, 02 Oct 2014 08:51:22 -0400
Received: from mail-wg0-x231.google.com ([2a00:1450:400c:c00::231]:57234)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1XZfqn-0000d5-4I
	for qemu-devel@nongnu.org; Thu, 02 Oct 2014 08:51:17 -0400
Received: by mail-wg0-f49.google.com with SMTP id x12so3019703wgg.8
	for <qemu-devel@nongnu.org>; Thu, 02 Oct 2014 05:51:15 -0700 (PDT)
Date: Thu, 2 Oct 2014 13:51:12 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20141002125112.GA30564@stefanha-thinkpad.redhat.com>
References: <1411437381-11234-1-git-send-email-famz@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="bp/iNruPH9dso1Pn"
Content-Disposition: inline
In-Reply-To: <1411437381-11234-1-git-send-email-famz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v5] vmdk: Fix integer overflow in offset
 calculation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, Max Reitz <mreitz@redhat.com>


--bp/iNruPH9dso1Pn
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Sep 23, 2014 at 09:56:21AM +0800, Fam Zheng wrote:
> This fixes the bug introduced by commit c6ac36e (vmdk: Optimize cluster
> allocation).
>=20
> $ ~/build/master/qemu-io /stor/vm/arch.vmdk -c 'write 2G 1k'
> write failed: Invalid argument
>=20
> Reported-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> Reviewed-by: Max Reitz <mreitz@redhat.com>
> Signed-off-by: Fam Zheng <famz@redhat.com>
>=20
> ---
> v5: Fix group file and output reference. (Max)
> v4: Fix typo in file header: 1014 -> 2014.
> v3: A new case 105 instead of embedding in 005. (Max)
> ---
>  block/vmdk.c               |  2 +-
>  tests/qemu-iotests/105     | 70 ++++++++++++++++++++++++++++++++++++++++=
++++++
>  tests/qemu-iotests/105.out | 21 ++++++++++++++
>  tests/qemu-iotests/group   |  1 +
>  4 files changed, 93 insertions(+), 1 deletion(-)
>  create mode 100755 tests/qemu-iotests/105
>  create mode 100644 tests/qemu-iotests/105.out

Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block

Stefan

--bp/iNruPH9dso1Pn
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJULUpAAAoJEJykq7OBq3PIU+wH/1EWHur2Zasfhp/zJkGrUJ4x
Uo/cXcU93V8uRdCz1k14W1kQYrPpz8sU3kJIXJyxhJCnf9t5vPxmKhW8rVHqUpuJ
JpJEtZa6OXBH69UxHzwbv2uOXV88q67p0wXjtd21F6sFtSx/fnVfdhdSWreAqY1d
jf1dmLpcmd3tfb2EYUa1xzjmgxO0x2rxvo+AErkoOfTIYrja0ezDdeTODt4Pn2QQ
HeZfi0igCKf0j9RcKanHztJtMdC3XPtxW1JLsWuwJBzfUoIvbhKz2i+9O/jCi3X7
NDXQM01F2v8az7UwWYHHhT5e9JEWH7SyEIYCYjWg2JZpLgBDFzK/VsDABAigkk8=
=SsL2
-----END PGP SIGNATURE-----

--bp/iNruPH9dso1Pn--