From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45681)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1XZgHI-00068z-3s
	for qemu-devel@nongnu.org; Thu, 02 Oct 2014 09:18:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1XZgH9-0007YQ-3E
	for qemu-devel@nongnu.org; Thu, 02 Oct 2014 09:18:40 -0400
Received: from mail-wi0-x22d.google.com ([2a00:1450:400c:c05::22d]:38148)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1XZgH8-0007YE-T2
	for qemu-devel@nongnu.org; Thu, 02 Oct 2014 09:18:31 -0400
Received: by mail-wi0-f173.google.com with SMTP id bs8so3927365wib.12
	for <qemu-devel@nongnu.org>; Thu, 02 Oct 2014 06:18:30 -0700 (PDT)
Date: Thu, 2 Oct 2014 14:18:26 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20141002131826.GC30564@stefanha-thinkpad.redhat.com>
References: <1412078370-3555-1-git-send-email-armbru@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="oJ71EGRlYNjSvfq7"
Content-Disposition: inline
In-Reply-To: <1412078370-3555-1-git-send-email-armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] util: Emancipate id_wellformed() from
 QemuOpts
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com


--oJ71EGRlYNjSvfq7
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Sep 30, 2014 at 01:59:30PM +0200, Markus Armbruster wrote:
> +bool id_wellformed(const char *id)
> +{
> +    int i;
> +
> +    if (!qemu_isalpha(id[0])) {
> +        return 0;

false would be a bit nicer since the other return cases use true/false.

--oJ71EGRlYNjSvfq7
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJULVCiAAoJEJykq7OBq3PIswkH/3Pl4HhbQjOr9zUfpFzq/GjW
9j4ashnqMyvEBeXugbqo96dRtL9g9oBnM/tRJZ8oXBoxqgMxkZ0SZF2wHxAnpMC9
W+I/9y+NF5rqrJJy9Iqv3RBFSUHLu5mTDuv6PvAsot3in3FrfvM79oso4SXJJtLD
gFJ271OmgK+GRbbncAeaPg5jBJBsRyfoa5Jf9eCeYZXGJJg5Q6z5dNWwwLnjs6p2
ZYwEwz54YaPoeZ/f8DSZUrBplALr+/7eo922MAlKgCKn6G4kz/pPy7pjxenhnCul
0O0OV1Kl2lfO9+6AY3SW+67xdFCMJDWjpKc7azmg2Qd72iOjkkxwGFLSZI9XitE=
=8DRr
-----END PGP SIGNATURE-----

--oJ71EGRlYNjSvfq7--