From: "Michael S. Tsirkin" <mst@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: jsnow@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/6] pc: bring ACPI table size below to 2.0 levels, try fixing -initrd for good
Date: Thu, 2 Oct 2014 16:49:05 +0300 [thread overview]
Message-ID: <20141002134905.GC26273@redhat.com> (raw)
In-Reply-To: <542D5687.3050604@redhat.com>
On Thu, Oct 02, 2014 at 03:43:35PM +0200, Paolo Bonzini wrote:
> Il 02/10/2014 15:41, Michael S. Tsirkin ha scritto:
> > On Thu, Oct 02, 2014 at 03:30:57PM +0200, Paolo Bonzini wrote:
> >> These patches do fix John's scenario, but that is not the main issue.
> >> They are not an _attempt_ to fix it, they just do so more or less by
> >> chance. Their real purpose is fixing the second issue:
> >>
> >>> - table size changes cause cross version migration issues
> >>> this is really due to the fact we are using RAM
> >>> to migrate ACPI tables.
> >>> IMHO a more robust fix would be to allow RAM size to change
> >>> during migration, or to avoid using RAM, switch to another type of
> >>> object.
> >>
> >> Allowing fw_cfg size to change during migration (does not matter if it
> >> is stored in RAM or otherwise) is a huge can of worms because the host
> >> might have loaded the size and stored it somewhere, way before migration.
> >
> > Right. I'm not suggesting it. I suggest migrating fw cfg size instead.
> >
> > The issue is that incoming migration might have a different
> > fw_cfg size from what we have.
>
> Understood now.
>
> > I think migrating this value will solve the issue in a cleaner way.
>
> Perhaps. The question is whether it would complicate the
> forwards-migration code beyond what is sane. I think we are practically
> speaking stuck with RAM.
>
> Paolo
Migrating RAM size is actually useful too, I think someone asked for it.
--
MST
next prev parent reply other threads:[~2014-10-02 13:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-18 16:17 [Qemu-devel] [PATCH 0/6] pc: bring ACPI table size below to 2.0 levels, try fixing -initrd for good Paolo Bonzini
2014-09-18 16:17 ` [Qemu-devel] [PATCH 1/6] pc: initialize fw_cfg earlier Paolo Bonzini
2014-09-18 16:17 ` [Qemu-devel] [PATCH 2/6] pc: load the kernel after ACPI tables are built Paolo Bonzini
2014-09-18 16:17 ` [Qemu-devel] [PATCH 3/6] pc: redo sizing of reserved high memory area for -kernel/-initrd Paolo Bonzini
2014-09-18 16:17 ` [Qemu-devel] [PATCH 4/6] pc: introduce new ACPI table sizing algorithm Paolo Bonzini
2014-09-18 16:17 ` [Qemu-devel] [PATCH 5/6] pc: go back to smaller ACPI tables Paolo Bonzini
2014-09-18 16:17 ` [Qemu-devel] [PATCH 6/6] pc: clean up pre-2.1 compatibility code Paolo Bonzini
2014-09-19 7:36 ` [Qemu-devel] [PATCH 0/6] pc: bring ACPI table size below to 2.0 levels, try fixing -initrd for good Gerd Hoffmann
2014-09-19 8:06 ` Paolo Bonzini
2014-09-19 13:09 ` Paolo Bonzini
2014-10-02 12:11 ` Michael S. Tsirkin
2014-10-02 12:44 ` Paolo Bonzini
2014-10-02 13:30 ` Paolo Bonzini
2014-10-02 13:41 ` Michael S. Tsirkin
2014-10-02 13:43 ` Paolo Bonzini
2014-10-02 13:49 ` Michael S. Tsirkin [this message]
2014-10-06 13:42 ` Paolo Bonzini
2014-10-06 13:52 ` Michael S. Tsirkin
2014-10-06 13:55 ` Paolo Bonzini
2014-10-06 14:12 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141002134905.GC26273@redhat.com \
--to=mst@redhat.com \
--cc=jsnow@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).