From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38241) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XZhc1-00033r-Ex for qemu-devel@nongnu.org; Thu, 02 Oct 2014 10:44:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XZhbv-0000i1-Py for qemu-devel@nongnu.org; Thu, 02 Oct 2014 10:44:09 -0400 Received: from mail-wg0-x22c.google.com ([2a00:1450:400c:c00::22c]:61164) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XZhbv-0000hd-7w for qemu-devel@nongnu.org; Thu, 02 Oct 2014 10:44:03 -0400 Received: by mail-wg0-f44.google.com with SMTP id y10so3244637wgg.27 for ; Thu, 02 Oct 2014 07:44:02 -0700 (PDT) Date: Thu, 2 Oct 2014 15:43:59 +0100 From: Stefan Hajnoczi Message-ID: <20141002144359.GC6250@stefanha-thinkpad.redhat.com> References: <1412187569-23452-1-git-send-email-jsnow@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="4jXrM3lyYWu4nBt5" Content-Disposition: inline In-Reply-To: <1412187569-23452-1-git-send-email-jsnow@redhat.com> Subject: Re: [Qemu-devel] [PATCH v3 0/6] Q35: Implement -cdrom/-hda sugar List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow Cc: kwolf@redhat.com, mst@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, armbru@redhat.com --4jXrM3lyYWu4nBt5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 01, 2014 at 02:19:23PM -0400, John Snow wrote: > The Q35 board initialization does not currently bother to look > for any drives added by the various syntactical sugar shorthands > to be added to the AHCI HBA. These include -hda through -hdd, > -cdrom, and -drive if=3Dide shorthands. >=20 > An obstacle to having implemented this sooner is debate over > whether or not to add an additional interface type, and how to > manage the different units-per-bus mappings of various HBA > implementations. >=20 > This patch series: > (1) Does not add IF_AHCI, but reuses IF_IDE > (2) Allows the if_max_devs table to be overridden > (3) Adds this override to the Q35 board type. > (4) Finally, adds implementation to Q35 initialization. >=20 > History: >=20 > V3: >=20 > - renamed a variable for consistency ("tab" to "hd") > - Now uses ARRAY_SIZE() for calls to ide_drive_get where applicable > - Re-added a call to exit() for the error pathway of ide_drive_get > - Adjusted drive_get_max_devs semantics to be similar to drive_get_max_bus > and added documentation > - Removed any possibility of a divide-by-zero in ide_drive_get >=20 > V2: > - Adjusted language in patch #1's commit message. > (drive if=3Dnone will NOT trigger warnings) > - Removed superfluous warning with bad phrasing in patch #1 > - Removed if_get_max_devs from patch #2 and added to patch #4 > - Added an assertion to patch #2 > - Added more detail to patch #3's commit message > - Specified that Patch #3 will affect old Q35 machine types > - Changed fprintf to error_report in patch #4 > - Replaced max_bus parameter in ide_drive_get with 'n', size of array > - Updated calls to ide_drive_get in other boards > - Adjusted language in patch #6's commit message. > (Removed reference to patch #5.) >=20 > V1: > - Re-uses ide_drive_get instead of ahci_drive_get > - Adds units-per-bus property to all Q35 machines > - Changes orphan scanning to exclude IF_NONE and > automatically added drives > - Renames 'units-per-idebus' to 'units-per-default-bus' > And allows override of any one IF type (block_default) >=20 > RFC2: > - Rewrote series to avoid the creation of IF_AHCI. >=20 > John Snow (6): > blockdev: Orphaned drive search > blockdev: Allow overriding if_max_dev property > pc/vl: Add units-per-default-bus property > ide: Update ide_drive_get to be HBA agnostic > qtest/bios-tables: Correct Q35 command line > q35/ahci: Pick up -cdrom and -hda options >=20 > blockdev.c | 64 +++++++++++++++++++++++++++++++++++++++++= +++++- > hw/alpha/dp264.c | 2 +- > hw/i386/pc.c | 1 + > hw/i386/pc_piix.c | 2 +- > hw/i386/pc_q35.c | 7 +++++- > hw/ide/ahci.c | 15 +++++++++++ > hw/ide/ahci.h | 2 ++ > hw/ide/core.c | 22 ++++++++++++---- > hw/mips/mips_fulong2e.c | 2 +- > hw/mips/mips_malta.c | 2 +- > hw/mips/mips_r4k.c | 2 +- > hw/ppc/mac_newworld.c | 2 +- > hw/ppc/mac_oldworld.c | 2 +- > hw/ppc/prep.c | 2 +- > hw/sparc64/sun4u.c | 2 +- > include/hw/boards.h | 2 ++ > include/sysemu/blockdev.h | 5 ++++ > tests/bios-tables-test.c | 10 +++----- > vl.c | 18 ++++++++++++- > 19 files changed, 141 insertions(+), 23 deletions(-) >=20 > --=20 > 1.9.3 >=20 >=20 Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan --4jXrM3lyYWu4nBt5 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJULWSvAAoJEJykq7OBq3PIO24IAMDMJHLdnLTc479jlgJVFpG7 r5MileSN0C/Rdm2bLBxRNmd0WJ0zTjEhLEYh/SnrqohRK2vXoeOwg+IIFlPVD8tD NGb9SMyPyERv15+e3MATxcj7cE+FzeANhytK9u1+y/FfR/lY0ud98ATpXK30gN3Q Ftntcuk6Qs8o7IGoCE9ucml2LDo978Boxw1ICqWAIkTRzUIfHFC3BM++w9VqKHtV PntLjBow8V7iBvOlDs2t9+GxpwfJWz1uFP4EJVuhazOosbVwywPXJZ8dmF6QmRU3 UqAcJDWfIj5AmMaw5+oIRgE1UHx0E9IhTGc7ow3kQAPK31vt+ERMzwcvMYefbJk= =pjNO -----END PGP SIGNATURE----- --4jXrM3lyYWu4nBt5--