From: "Michael S. Tsirkin" <mst@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: jsnow@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/6] pc: bring ACPI table size below to 2.0 levels, try fixing -initrd for good
Date: Mon, 6 Oct 2014 16:52:53 +0300 [thread overview]
Message-ID: <20141006135253.GA29563@redhat.com> (raw)
In-Reply-To: <54329C29.9070508@redhat.com>
On Mon, Oct 06, 2014 at 03:42:01PM +0200, Paolo Bonzini wrote:
> Il 02/10/2014 15:49, Michael S. Tsirkin ha scritto:
> >>> The issue is that incoming migration might have a different
> >>> fw_cfg size from what we have.
> >>
> >> Understood now.
> >>
> >>> I think migrating this value will solve the issue in a cleaner way.
> >>
> >> Perhaps. The question is whether it would complicate the
> >> forwards-migration code beyond what is sane. I think we are practically
> >> speaking stuck with RAM.
> >
> > Migrating RAM size is actually useful too, I think someone asked for it.
>
> Migrating RAM size was discussed for BIOS and option ROMs, in order to
> support migration from old versions of QEMU. It was floated around for
> some time, but ultimately we ended up shipping two copies of affected
> firmware (128k/256k BIOS, and non-EFI/EFI option ROMs).
>
> For BIOS it wouldn't be enough, because the BIOS size affects the memory
> map. Of course ACPI tables aren't mapped anywhere, but I'd be wary of
> adding code to migration that is half-broken and almost never used.
>
> Also, RAM blocks that have different size would be yet another thing
> that makes machine types "almost compatible" with the QEMU version
> they're supposed to represent. In a scenario similar to John's, with
> mutable RAM sizes, would have likely broken all machine types, because
> we would not have bothered doing full backwards-compatibility.
>
> I'm not an advocate of backwards bug-compatibility, but I think RAM
> block sizes are way beyond the line of what we should be allowed to
> modify between machine types.
>
> Paolo
Maybe we should just modify ACPI and rom files in general to use
something else, not RAM?
It looked like a good fit initially so we went ahead with it,
but these things are fairly small, so it's not a problem to
migrate them as part of the device state.
--
MST
next prev parent reply other threads:[~2014-10-06 13:49 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-18 16:17 [Qemu-devel] [PATCH 0/6] pc: bring ACPI table size below to 2.0 levels, try fixing -initrd for good Paolo Bonzini
2014-09-18 16:17 ` [Qemu-devel] [PATCH 1/6] pc: initialize fw_cfg earlier Paolo Bonzini
2014-09-18 16:17 ` [Qemu-devel] [PATCH 2/6] pc: load the kernel after ACPI tables are built Paolo Bonzini
2014-09-18 16:17 ` [Qemu-devel] [PATCH 3/6] pc: redo sizing of reserved high memory area for -kernel/-initrd Paolo Bonzini
2014-09-18 16:17 ` [Qemu-devel] [PATCH 4/6] pc: introduce new ACPI table sizing algorithm Paolo Bonzini
2014-09-18 16:17 ` [Qemu-devel] [PATCH 5/6] pc: go back to smaller ACPI tables Paolo Bonzini
2014-09-18 16:17 ` [Qemu-devel] [PATCH 6/6] pc: clean up pre-2.1 compatibility code Paolo Bonzini
2014-09-19 7:36 ` [Qemu-devel] [PATCH 0/6] pc: bring ACPI table size below to 2.0 levels, try fixing -initrd for good Gerd Hoffmann
2014-09-19 8:06 ` Paolo Bonzini
2014-09-19 13:09 ` Paolo Bonzini
2014-10-02 12:11 ` Michael S. Tsirkin
2014-10-02 12:44 ` Paolo Bonzini
2014-10-02 13:30 ` Paolo Bonzini
2014-10-02 13:41 ` Michael S. Tsirkin
2014-10-02 13:43 ` Paolo Bonzini
2014-10-02 13:49 ` Michael S. Tsirkin
2014-10-06 13:42 ` Paolo Bonzini
2014-10-06 13:52 ` Michael S. Tsirkin [this message]
2014-10-06 13:55 ` Paolo Bonzini
2014-10-06 14:12 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141006135253.GA29563@redhat.com \
--to=mst@redhat.com \
--cc=jsnow@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).