From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52896) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XbDNu-0000Ij-OW for qemu-devel@nongnu.org; Mon, 06 Oct 2014 14:51:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XbDNo-0004m4-8u for qemu-devel@nongnu.org; Mon, 06 Oct 2014 14:51:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59106) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XbDNo-0004lL-15 for qemu-devel@nongnu.org; Mon, 06 Oct 2014 14:51:44 -0400 Date: Mon, 6 Oct 2014 19:51:25 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20141006185124.GV2336@work-vm> References: <1412358473-31398-1-git-send-email-dgilbert@redhat.com> <1412358473-31398-39-git-send-email-dgilbert@redhat.com> <54303D4D.9060401@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54303D4D.9060401@redhat.com> Subject: Re: [Qemu-devel] [PATCH v4 38/47] Add assertion to check migration_dirty_pages List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: aarcange@redhat.com, yamahata@private.email.ne.jp, lilei@linux.vnet.ibm.com, quintela@redhat.com, cristian.klein@cs.umu.se, qemu-devel@nongnu.org, amit.shah@redhat.com, yanghy@cn.fujitsu.com * Paolo Bonzini (pbonzini@redhat.com) wrote: > Il 03/10/2014 19:47, Dr. David Alan Gilbert (git) ha scritto: > > > > I've seen it go negative once during dev, it shouldn't > > happen. > > You can move it earlier, perhaps even as patch 1, since it does not have > any dependency on postcopy and can go in at any time. OK, I moved it to the 2nd patch - just after the docs (Eric previously said he liked those at the start of a patch set). Dave > > Paolo -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK