From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54246) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XbDWx-0003Jk-4m for qemu-devel@nongnu.org; Mon, 06 Oct 2014 15:01:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XbDWr-0001eY-0z for qemu-devel@nongnu.org; Mon, 06 Oct 2014 15:01:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:18231) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XbDWq-0001eL-QS for qemu-devel@nongnu.org; Mon, 06 Oct 2014 15:01:04 -0400 Date: Mon, 6 Oct 2014 20:00:52 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20141006190051.GW2336@work-vm> References: <1412358473-31398-1-git-send-email-dgilbert@redhat.com> <1412358473-31398-33-git-send-email-dgilbert@redhat.com> <54302372.2050300@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54302372.2050300@redhat.com> Subject: Re: [Qemu-devel] [PATCH v4 32/47] postcopy: ram_enable_notify to switch on userfault List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: aarcange@redhat.com, yamahata@private.email.ne.jp, lilei@linux.vnet.ibm.com, quintela@redhat.com, cristian.klein@cs.umu.se, qemu-devel@nongnu.org, amit.shah@redhat.com, yanghy@cn.fujitsu.com * Paolo Bonzini (pbonzini@redhat.com) wrote: > Il 03/10/2014 19:47, Dr. David Alan Gilbert (git) ha scritto: > > +static int postcopy_ram_sensitise_area(const char *block_name, void *host_addr, > > + ram_addr_t offset, ram_addr_t length, > > + void *opaque) > > Weird name, and I'm not referring to the British -ise. :) > > Perhaps ram_block_enable_userfault or ram_block_enable_notify? It helps > clarity to limit the use of the "postcopy_ram_" prefix for static function. Yep, that's fair enough; I'll make it ram_block_enable_notify. Dave > Paolo -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK