From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56190) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XbDdg-00089Q-94 for qemu-devel@nongnu.org; Mon, 06 Oct 2014 15:08:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XbDdb-0005YY-0E for qemu-devel@nongnu.org; Mon, 06 Oct 2014 15:08:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38230) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XbDda-0005Y0-OH for qemu-devel@nongnu.org; Mon, 06 Oct 2014 15:08:02 -0400 Date: Mon, 6 Oct 2014 20:07:48 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20141006190748.GX2336@work-vm> References: <1412358473-31398-1-git-send-email-dgilbert@redhat.com> <1412358473-31398-21-git-send-email-dgilbert@redhat.com> <5432E679.5020104@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5432E679.5020104@redhat.com> Subject: Re: [Qemu-devel] [PATCH v4 20/47] Add migration-capability boolean for postcopy-ram. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: aarcange@redhat.com, yamahata@private.email.ne.jp, lilei@linux.vnet.ibm.com, quintela@redhat.com, cristian.klein@cs.umu.se, qemu-devel@nongnu.org, amit.shah@redhat.com, yanghy@cn.fujitsu.com * Eric Blake (eblake@redhat.com) wrote: > On 10/03/2014 11:47 AM, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Signed-off-by: Dr. David Alan Gilbert > > Reviewed-by: Eric Blake > > --- > > include/migration/migration.h | 1 + > > migration.c | 9 +++++++++ > > qapi-schema.json | 6 +++++- > > 3 files changed, 15 insertions(+), 1 deletion(-) > > > > > # > > +# @x-postcopy-ram: Start executing on the migration target before all of RAM has been > > +# migrated, pulling the remaining pages along as needed. NOTE: If the > > +# migration fails during postcopy the VM will fail. (since 2.2) > > +# > > # Since: 1.2 > > ## > > { 'enum': 'MigrationCapability', > > - 'data': ['xbzrle', 'rdma-pin-all', 'auto-converge', 'zero-blocks'] } > > + 'data': ['xbzrle', 'rdma-pin-all', 'auto-converge', 'zero-blocks', 'x-postcopy-ram'] } > > Can we wrap this to keep things in 80 columns? Done. > Also, the question was > raised on the libvirt list on whether the interface is stable enough to > name this 'postcopy-ram' from the get-go (rather than marking the > interface experimental), so that libvirt can start using it sooner. I'm still nervous about that, what I intend to do is add one patch at the end of the series that removes the x- so that can get discussed separately. While I'm confident that the interface to libvirt is stable, removing the x- declares that the whole thing is stable and I then have to maintain migration compatibility; and it seemed sensible to let people try it for a release; however if libvirt have no way to support QEMUs ability to have experimental features, I guess no one is actually going to try it, which is very disappointing. Dave > -- > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK