From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58360) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XbDk9-0006tM-05 for qemu-devel@nongnu.org; Mon, 06 Oct 2014 15:14:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XbDk2-0000zN-23 for qemu-devel@nongnu.org; Mon, 06 Oct 2014 15:14:48 -0400 Received: from e06smtp15.uk.ibm.com ([195.75.94.111]:41153) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XbDk1-0000z0-Ox for qemu-devel@nongnu.org; Mon, 06 Oct 2014 15:14:41 -0400 Received: from /spool/local by e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 6 Oct 2014 20:14:39 +0100 Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 86EB62190045 for ; Mon, 6 Oct 2014 20:14:14 +0100 (BST) Received: from d06av11.portsmouth.uk.ibm.com (d06av11.portsmouth.uk.ibm.com [9.149.37.252]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id s96JEa7756951032 for ; Mon, 6 Oct 2014 19:14:36 GMT Received: from d06av11.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av11.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s96JEZCp013937 for ; Mon, 6 Oct 2014 13:14:36 -0600 Date: Mon, 6 Oct 2014 21:14:33 +0200 From: David Hildenbrand Message-ID: <20141006211433.13e63cf0@thinkpad-w530> In-Reply-To: References: <1412090627-18709-1-git-send-email-jfrei@linux.vnet.ibm.com> <1412090627-18709-2-git-send-email-jfrei@linux.vnet.ibm.com> <20141006170807.4f48fcf8.cornelia.huck@de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] gdb: provide the name of the architecture in the target.xml List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Alexander Graf , QEMU Developers , Christian Borntraeger , Jens Freimann , "Vassili Karpov (malc)" , Cornelia Huck , Edgar Iglesias , Richard Henderson > On 6 October 2014 16:08, Cornelia Huck wrote: > > On Tue, 30 Sep 2014 17:23:47 +0200 > > Jens Freimann wrote: > > > >> From: David Hildenbrand > >> > >> This patch provides the name of the architecture in the target.xml if = available. > >> > >> This allows the remote gdb to detect the target architecture on its ow= n - so > >> there is no need to specify it manually (e.g. if gdb is started withou= t a > >> binary) using "set arch *arch_name*". > >> > >> The name of the architecture has been added to all archs that provide a > >> target.xml (by supplying a gdb_core_xml_file) and have a unique archit= ecture > >> name in gdb's feature xml files. > >> > >> Signed-off-by: David Hildenbrand > >> Acked-by: Cornelia Huck > >> Acked-by: Christian Borntraeger > >> Signed-off-by: Jens Freimann > >> Reviewed-by: Andreas F=C3=A4rber > >> Cc: Andrzej Zaborowski > >> Cc: Peter Maydell > >> Cc: Vassili Karpov (malc) > >> CC: Edgar Iglesias > >> CC: Richard Henderson > >> --- > >> gdbstub.c | 19 ++++++++++++------- > >> include/qom/cpu.h | 2 ++ > >> target-arm/cpu64.c | 1 + > >> target-ppc/translate_init.c | 2 ++ > >> target-s390x/cpu.c | 1 + > >> 5 files changed, 18 insertions(+), 7 deletions(-) > >> > > I will send this with the next pile of s390x updates, unless someone on > > cc: has any objections. >=20 > I'm still hoping for an answer about why this is setting > the name for 64 bit ARM and not 32 bit ARM, and whether > there are any cases which need to actually be able to set > the architecture name in a more complicated name than > simply a string. I raised those in the last lot of review > and there doesn't seem to have been any answer. >=20 > thanks > -- PMM >=20 Hi Peter, actually the questions were addressed in the last review. Haven't received = any answer from you to my reply. Maybe some mails got lost in the system. 32bit arm: -"On my way through the possible architecture names (binutils-gdb/gdb/features/*.xml), I wasn't able to come up with the righ= t name for arm 32 bit (arm-core.xml) - they don't specify any. This patch theref= ore adapts to the xml files from gdb." - Not included in this patch as Edgar provided a patch in the previous thre= ad (that's why he is on cc) that can easily be adopted. I don't want to simp= ly include his effort in my patch :) And we have to make sure that this name= is the right one. More complicated names: - "The architecture should be known at the same point when specifying the x= ml file. So if anyone can come up with the proper arm name in the future (or= even some kind of detection algorithm), it can simply be set in target-arm/cpu.c (a= fter "arm-core.xml")." - The same should apply for all architectures. So we can set (or even build) the proper string when also specifying the core xml file. Do you have something in mind like your "powerpc:common" and "powerpc:e500" example? To build the names based on some pattern? I don't think that we can generalize the name format here (at least "aarch6= 4" makes me assume that :) ). I think it would be enough to set the complete strings in the class init functions. What do you think? Any suggestions? Thanks! David