From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Chen, Tiejun" <tiejun.chen@intel.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
"Kay, Allen M" <allen.m.kay@intel.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough
Date: Tue, 7 Oct 2014 10:27:51 +0300 [thread overview]
Message-ID: <20141007072751.GC2424@redhat.com> (raw)
In-Reply-To: <54279EE3.3050208@intel.com>
On Sun, Sep 28, 2014 at 01:38:43PM +0800, Chen, Tiejun wrote:
> >**errp)
> >{
> > uint32_t value = 0;
> > XenHostPCIDevice hdev;
> > int r = 0, num;
> >
> > r = xen_host_pci_device_get(&hdev, 0, 0, 0x02, 0);
> > if (!r) {
> > value = hdev.device_id;
> >
> > num = sizeof(xen_igd_combo_id_infos)/sizeof(uint16_t);
>
> Sorry for this one typo:
>
> sizeof(xen_igd_combo_id_infos)/sizeof(xen_igd_combo_id_infos[0]);
>
> Tiejun
so don't opencode this, use ARRAY_SIZE.
next prev parent reply other threads:[~2014-10-07 7:24 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-21 1:28 [Qemu-devel] [PATCH 0/2] qemu:xen: implement isa bridge specific to IGD passthrough Tiejun Chen
2014-08-21 1:28 ` [Qemu-devel] [PATCH 1/2] hw:xen:xen_pt: register " Tiejun Chen
2014-08-21 1:28 ` [Qemu-devel] [PATCH 2/2] xen:i386:pc_piix: create " Tiejun Chen
2014-08-21 16:16 ` [Qemu-devel] [Xen-devel] " Konrad Rzeszutek Wilk
2014-08-22 1:06 ` Chen, Tiejun
2014-08-24 11:12 ` Michael S. Tsirkin
2014-08-25 5:18 ` Chen, Tiejun
2014-08-26 2:49 ` Chen, Tiejun
2014-08-28 0:56 ` Chen, Tiejun
2014-08-29 1:28 ` Chen, Tiejun
2014-08-31 8:58 ` Michael S. Tsirkin
2014-09-01 2:50 ` Chen, Tiejun
2014-09-01 6:05 ` Michael S. Tsirkin
2014-09-01 7:49 ` Chen, Tiejun
2014-09-03 1:40 ` Kay, Allen M
2014-09-03 6:27 ` Michael S. Tsirkin
2014-09-03 15:06 ` Kay, Allen M
2014-09-28 2:59 ` Chen, Tiejun
2014-09-28 5:38 ` Chen, Tiejun
2014-10-07 7:27 ` Michael S. Tsirkin [this message]
2014-10-09 2:16 ` Chen, Tiejun
2014-09-29 10:01 ` Michael S. Tsirkin
2014-09-30 2:43 ` Chen, Tiejun
2014-10-07 1:02 ` Chen, Tiejun
2014-10-07 7:26 ` Michael S. Tsirkin
2014-10-09 5:53 ` Chen, Tiejun
2014-10-12 9:50 ` Michael S. Tsirkin
2014-10-24 7:36 ` Chen, Tiejun
2014-10-24 13:47 ` Michael S. Tsirkin
2014-10-30 7:47 ` Chen, Tiejun
2014-11-03 7:48 ` Chen, Tiejun
2014-11-03 11:35 ` Paolo Bonzini
2014-11-03 11:36 ` Chen, Tiejun
2014-11-03 11:47 ` Chen, Tiejun
2014-11-03 12:01 ` Paolo Bonzini
2014-11-03 13:10 ` Michael S. Tsirkin
2014-11-05 7:23 ` Chen, Tiejun
2014-08-22 18:23 ` [Qemu-devel] " Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141007072751.GC2424@redhat.com \
--to=mst@redhat.com \
--cc=allen.m.kay@intel.com \
--cc=konrad.wilk@oracle.com \
--cc=qemu-devel@nongnu.org \
--cc=tiejun.chen@intel.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).