From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34165)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1XbP8L-0003lV-AU
	for qemu-devel@nongnu.org; Tue, 07 Oct 2014 03:24:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1XbP8C-0000bi-4i
	for qemu-devel@nongnu.org; Tue, 07 Oct 2014 03:24:33 -0400
Received: from mx1.redhat.com ([209.132.183.28]:53580)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1XbP8B-0000bc-Tg
	for qemu-devel@nongnu.org; Tue, 07 Oct 2014 03:24:24 -0400
Date: Tue, 7 Oct 2014 10:27:51 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20141007072751.GC2424@redhat.com>
References: <53FBF5BD.6060104@intel.com> <53FE7E3A.7050907@intel.com>
	<53FFD752.2040402@intel.com> <20140831085857.GC1514@redhat.com>
	<5403DEFD.1020704@intel.com> <20140901060506.GA20186@redhat.com>
	<54042514.6090206@intel.com>
	<003AAFE53969E14CB1F09B6FD68C3CD478F16D2A@ORSMSX101.amr.corp.intel.com>
	<54277979.7070408@intel.com> <54279EE3.3050208@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <54279EE3.3050208@intel.com>
Subject: Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create
 isa bridge specific to IGD passthrough
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Chen, Tiejun" <tiejun.chen@intel.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>, "Kay,
	Allen M" <allen.m.kay@intel.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

On Sun, Sep 28, 2014 at 01:38:43PM +0800, Chen, Tiejun wrote:
> >**errp)
> >{
> >     uint32_t value = 0;
> >     XenHostPCIDevice hdev;
> >     int r = 0, num;
> >
> >     r = xen_host_pci_device_get(&hdev, 0, 0, 0x02, 0);
> >     if (!r) {
> >         value = hdev.device_id;
> >
> >         num = sizeof(xen_igd_combo_id_infos)/sizeof(uint16_t);
> 
> Sorry for this one typo:
> 
> sizeof(xen_igd_combo_id_infos)/sizeof(xen_igd_combo_id_infos[0]);
> 
> Tiejun


so don't opencode this, use ARRAY_SIZE.