From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47918) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XbmXW-0004mu-PN for qemu-devel@nongnu.org; Wed, 08 Oct 2014 04:24:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XbmXR-0007BE-R9 for qemu-devel@nongnu.org; Wed, 08 Oct 2014 04:24:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:12918) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XbmXR-0007B0-JZ for qemu-devel@nongnu.org; Wed, 08 Oct 2014 04:24:01 -0400 Date: Wed, 8 Oct 2014 09:23:41 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20141008082340.GC2521@work-vm> References: <1411983695-7910-1-git-send-email-dgilbert@redhat.com> <1411983695-7910-2-git-send-email-dgilbert@redhat.com> <5434A6D7.50209@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5434A6D7.50209@huawei.com> Subject: Re: [Qemu-devel] [PATCH v5 1/2] QEMUSizedBuffer based QEMUFile List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: zhanghailiang Cc: joel.schopp@amd.com, quintela@redhat.com, stefanb@linux.vnet.ibm.com, qemu-devel@nongnu.org, arei.gonglei@huawei.com, sanidhya.iiith@gmail.com * zhanghailiang (zhang.zhanghailiang@huawei.com) wrote: > On 2014/9/29 17:41, Dr. David Alan Gilbert (git) wrote: > >+static ssize_t qsb_grow(QEMUSizedBuffer *qsb, size_t new_size) > >+{ > >+ size_t needed_chunks, i; > >+ > >+ if (qsb->size < new_size) { > >+ struct iovec *new_iov; > >+ size_t size_diff = new_size - qsb->size; > >+ size_t chunk_size = (size_diff > QSB_MAX_CHUNK_SIZE) > >+ ? QSB_MAX_CHUNK_SIZE : QSB_CHUNK_SIZE; > >+ > >+ needed_chunks = DIV_ROUND_UP(size_diff, chunk_size); > >+ > >+ new_iov = g_try_malloc_n(qsb->n_iov + needed_chunks, > >+ sizeof(struct iovec)); > > It seems that *g_try_malloc_n* was supported since glib2-2.24 version, > But it don't check this when do *configure* before compile...;) OK, that's a shame - it was a nice easy function to use :-) I'll fix it. Dave -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK