From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52114) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xbp3w-0005BG-LT for qemu-devel@nongnu.org; Wed, 08 Oct 2014 07:05:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xbp3q-0005nb-Ik for qemu-devel@nongnu.org; Wed, 08 Oct 2014 07:05:44 -0400 Received: from dew.nodalink.com ([95.130.14.197]:40216) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xbp3q-0005nH-CJ for qemu-devel@nongnu.org; Wed, 08 Oct 2014 07:05:38 -0400 Date: Wed, 8 Oct 2014 11:05:53 +0000 From: =?iso-8859-1?Q?Beno=EEt?= Canet Message-ID: <20141008110553.GA32479@nodalink.com> References: <1412688279-8312-1-git-send-email-benoit.canet@nodalink.com> <1412688279-8312-8-git-send-email-benoit.canet@nodalink.com> <20141008065338.GD15829@fam-t430.nay.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20141008065338.GD15829@fam-t430.nay.redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v1 7/8] throttle: Add throttle group support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: kwolf@redhat.com, stefanha@redhat.com, qemu-devel@nongnu.org, =?iso-8859-1?Q?Beno=EEt?= Canet On Wed, Oct 08, 2014 at 02:53:38PM +0800, Fam Zheng wrote: >=20 > Does this mean that after this series, all the throttle_states must be > contained inside its own throttle group? If so, we could embed Throttle= Group > fields in ThrottleState. >=20 > It's weird when a function called throttle_group_compare takes a parame= ter of > ThrottleState pointer, and cast it back to ThrottleGroup with container= _of. It's done like this to fullfill a design goal: the throttle should be reu= sable without the groups and any reference to block related stuff. So it's just a way to split the responsabilities. Best regards Beno=EEt Thanks for reviewing. >=20 > Fam