From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57713)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1XcEoI-0006jF-P6
	for qemu-devel@nongnu.org; Thu, 09 Oct 2014 10:35:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1XcEoC-0000mK-LG
	for qemu-devel@nongnu.org; Thu, 09 Oct 2014 10:35:18 -0400
Received: from mx1.redhat.com ([209.132.183.28]:40182)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1XcEoC-0000m5-EW
	for qemu-devel@nongnu.org; Thu, 09 Oct 2014 10:35:12 -0400
Date: Thu, 9 Oct 2014 09:47:51 -0400
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20141009094751.6e04b4b9@redhat.com>
In-Reply-To: <8761g4cgq3.fsf@blackfin.pond.sub.org>
References: <1411144812-22958-1-git-send-email-armbru@redhat.com>
	<8761g4cgq3.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/1] hmp: Remove "info pcmcia"
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, zhang.zhanghailiang@huawei.com

On Wed, 01 Oct 2014 10:54:44 +0200
Markus Armbruster <armbru@redhat.com> wrote:

> Ping?
> 
> Markus Armbruster <armbru@redhat.com> writes:
> 
> > This command lists PCMCIA sockets and cards.  Only a few ARM boards
> > have sockets (akita, borzoi, connex, mainstone, spitz, terrier, tosa,
> > verdex, z2), the only card is the DSCM-1xxxx Hitachi Microdrive (qdev
> > "microdrive"), and it is only inserted during machine init, if ever.
> > So this command doesn't really tell anybody anything new so far.
> >
> > Moreover, pcmcia_socket_unregister() has a use-after-free bug, flagged
> > by Coverity.  Has never been used, because there has never been code
> > to eject a PCMCIA card.
> >
> > Not worth fixing & converting to QMP.  Remove it.

Sorry for the long delay on this one. But this patch is more about PCMCIA
support in QEMU than HMP, so I can provide my ACK, but I don't think this
is HMP material.

Acked-by: Luiz Capitulino <lcapitulino@redhat.com>