From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36338)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@nodalink.com>) id 1XcIv4-0001ma-Pm
	for qemu-devel@nongnu.org; Thu, 09 Oct 2014 14:58:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <benoit.canet@nodalink.com>) id 1XcIuy-0000I9-IR
	for qemu-devel@nongnu.org; Thu, 09 Oct 2014 14:58:34 -0400
Received: from dew.nodalink.com ([95.130.14.197]:40351)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@nodalink.com>) id 1XcIuy-0000HW-C8
	for qemu-devel@nongnu.org; Thu, 09 Oct 2014 14:58:28 -0400
Date: Thu, 9 Oct 2014 18:58:45 +0000
From: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@nodalink.com>
Message-ID: <20141009185845.GA5717@nodalink.com>
References: <1411400179-10605-1-git-send-email-mreitz@redhat.com>
	<543593D7.4070909@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <543593D7.4070909@redhat.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v2 0/2] raw-posix: Fix
	raw_co_get_block_status()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Reitz <mreitz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@nodalink.com>

On Wed, Oct 08, 2014 at 09:43:19PM +0200, Max Reitz wrote:
> On 22.09.2014 17:36, Max Reitz wrote:
> >raw_co_get_block_status() should return 0 and set *pnum to 0 after the
> >EOF; currently it does this merely by accident, so implement it
> >directly. Also, nb_sectors should be clamped against the image end.
> >
> >While doing that, centralize the generation of
> >raw_co_get_block_status()'s return value along the way.
> >
> >
> >v2:
> >- Patch 1: Clamp nb_sectors against image end
> >- Patch 2: Fix alignment issue
> >
> >
> >Max Reitz (2):
> >   raw-posix: Fix raw_co_get_block_status() after EOF
> >   raw-posix: raw_co_get_block_status() return value
> >
> >  block/raw-posix.c | 36 ++++++++++++++++++++++--------------
> >  1 file changed, 22 insertions(+), 14 deletions(-)
>=20
> Ping. (This should be rather simple to review)

Hi Max,

I will review these tomorow.

Best regards

Beno=EEt